You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/11/18 20:55:13 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request #2364: Improve generics in InternalCompactionExecutor
ctubbsii opened a new pull request #2364:
URL: https://github.com/apache/accumulo/pull/2364
Fix #2362 by using InternalJob as the generic type instead of
Runnable for the PriorityBlockingQueue and its corresponding
Comparator in InternalCompactionExecutor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2364: Improve generics in InternalCompactionExecutor
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2364:
URL: https://github.com/apache/accumulo/pull/2364#issuecomment-973271761
On second thought, I don't think this is a good idea. Even if it worked, it makes too many assumptions about how the blocking queue is used internally to the executor. But, I don't think it will work anyway, because the comparator generic type won't match the wrapped Runnable type from OpenTelemetry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed pull request #2364: Improve generics in InternalCompactionExecutor
Posted by GitBox <gi...@apache.org>.
ctubbsii closed pull request #2364:
URL: https://github.com/apache/accumulo/pull/2364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org