You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/30 01:10:22 UTC

[GitHub] [incubator-iotdb] yuqi1129 opened a new pull request #1782: [IOTDB-927] Remove fastjson introduced by rocketmq

yuqi1129 opened a new pull request #1782:
URL: https://github.com/apache/incubator-iotdb/pull/1782


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1782: [IOTDB-927] Remove fastjson introduced by rocketmq

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1782:
URL: https://github.com/apache/incubator-iotdb/pull/1782#issuecomment-701109548


   @liuruiyiyang , can you have an evaluation for this change?  I am not sure whether RocketMQ client can run as normal if there is no a JSON dependency.
   By the way, is there some useful UT/IT that can be introduced from RocektMQ here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] liuruiyiyang commented on pull request #1782: [IOTDB-927] Remove fastjson introduced by rocketmq

Posted by GitBox <gi...@apache.org>.
liuruiyiyang commented on pull request #1782:
URL: https://github.com/apache/incubator-iotdb/pull/1782#issuecomment-701205486


   The fastJson is a dependency of rocketmq-client indeed, since it is used in the rocketmq-remoting component for serialization which is used by almost all rocketmq component including broker, name server and client.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org