You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/15 14:30:41 UTC

[GitHub] [flink-statefun-playground] tillrohrmann opened a new pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

tillrohrmann opened a new pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26


   This PR is based on #25. It updates the playground to use the newly introduced playground ingress/egress. By using the curl based ingress/egresses we can simplify the overall setup and get rid of some helper functions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tillrohrmann commented on pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26#issuecomment-1040593263


   Thanks for the quick review @igalshilman :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tillrohrmann commented on pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26#issuecomment-1041217623


   Merging this PR now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] igalshilman commented on a change in pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26#discussion_r807145842



##########
File path: java/greeter/docker-compose.yml
##########
@@ -35,51 +35,12 @@ services:
   ###############################################################
 
   statefun:
-    image: apache/flink-statefun-playground:3.2.0
+    image: apache/flink-statefun-playground:3.2.0-1.0

Review comment:
       You are right, let's use that exactly as you have it in this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] igalshilman commented on a change in pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26#discussion_r807070745



##########
File path: java/greeter/docker-compose.yml
##########
@@ -35,51 +35,12 @@ services:
   ###############################################################
 
   statefun:
-    image: apache/flink-statefun-playground:3.2.0
+    image: apache/flink-statefun-playground:3.2.0-1.0

Review comment:
       I don't think it is needed, you can republish the same docker image (`apache/flink-statefun-playground:3.2.0`)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tillrohrmann commented on a change in pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26#discussion_r807137563



##########
File path: java/greeter/docker-compose.yml
##########
@@ -35,51 +35,12 @@ services:
   ###############################################################
 
   statefun:
-    image: apache/flink-statefun-playground:3.2.0
+    image: apache/flink-statefun-playground:3.2.0-1.0

Review comment:
       Oh really? So it would only be a problem if it is cached somewhere, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tillrohrmann merged pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
tillrohrmann merged pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] igalshilman commented on a change in pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26#discussion_r807070745



##########
File path: java/greeter/docker-compose.yml
##########
@@ -35,51 +35,12 @@ services:
   ###############################################################
 
   statefun:
-    image: apache/flink-statefun-playground:3.2.0
+    image: apache/flink-statefun-playground:3.2.0-1.0

Review comment:
       I don't think it is needed, you can republish the same docker image (`apache/flink-statefun-playground:3.2.0`)
   

##########
File path: java/greeter/docker-compose.yml
##########
@@ -35,51 +35,12 @@ services:
   ###############################################################
 
   statefun:
-    image: apache/flink-statefun-playground:3.2.0
+    image: apache/flink-statefun-playground:3.2.0-1.0

Review comment:
       You are right, let's use that exactly as you have it in this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tillrohrmann commented on a change in pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26#discussion_r807137563



##########
File path: java/greeter/docker-compose.yml
##########
@@ -35,51 +35,12 @@ services:
   ###############################################################
 
   statefun:
-    image: apache/flink-statefun-playground:3.2.0
+    image: apache/flink-statefun-playground:3.2.0-1.0

Review comment:
       Oh really? So it would only be a problem if it is cached somewhere, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun-playground] tillrohrmann commented on pull request #26: [FLINK-26158] Update the playground examples to use the playground ingress/egress

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #26:
URL: https://github.com/apache/flink-statefun-playground/pull/26#issuecomment-1040593263


   Thanks for the quick review @igalshilman :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org