You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 13:12:07 UTC

[GitHub] [flink] sjwiesman opened a new pull request #12041: Spe

sjwiesman opened a new pull request #12041:
URL: https://github.com/apache/flink/pull/12041


   ## What is the purpose of the change
   
   Pass undelrying configuration option to SavepointEnvironment to configure IOManager.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

sjwiesman commented on pull request #12041:
URL: https://github.com/apache/flink/pull/12041#issuecomment-629398367


   @tzulitai could you look at this. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12041:
URL: https://github.com/apache/flink/pull/12041#issuecomment-625871059


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d277caea34897278157174cdeda2e22c4f2dd1fa",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=834",
       "triggerID" : "d277caea34897278157174cdeda2e22c4f2dd1fa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d277caea34897278157174cdeda2e22c4f2dd1fa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=834) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on a change in pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

StephanEwen commented on a change in pull request #12041:
URL: https://github.com/apache/flink/pull/12041#discussion_r426183040



##########
File path: flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/BootstrapTransformation.java
##########
@@ -36,13 +36,12 @@
 import org.apache.flink.state.api.output.operators.BroadcastStateBootstrapOperator;
 import org.apache.flink.state.api.output.partitioner.HashSelector;
 import org.apache.flink.state.api.output.partitioner.KeyGroupRangePartitioner;
-import org.apache.flink.state.api.runtime.BoundedStreamConfig;
+import org.apache.flink.streaming.api.CheckpointingMode;
 import org.apache.flink.streaming.api.graph.StreamConfig;
 import org.apache.flink.streaming.api.operators.StreamOperator;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
-

Review comment:
       This empty line removal is breaking checkstyle.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12041:
URL: https://github.com/apache/flink/pull/12041#issuecomment-625871059


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d277caea34897278157174cdeda2e22c4f2dd1fa",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=834",
       "triggerID" : "d277caea34897278157174cdeda2e22c4f2dd1fa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d277caea34897278157174cdeda2e22c4f2dd1fa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=834) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

sjwiesman commented on pull request #12041:
URL: https://github.com/apache/flink/pull/12041#issuecomment-630376259


   Fixed in
   Master: 7934fc04ac098e2143cab9459b216725fe1b8be6
   release-1.11: ce10080de0e6c35d60147318381c096cf77ec252
   release-1.10: 313051c0ffdacb1bca2d26482bd9bc7036bf9fd2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman closed pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

sjwiesman closed pull request #12041:
URL: https://github.com/apache/flink/pull/12041


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12041:
URL: https://github.com/apache/flink/pull/12041#issuecomment-625810298

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit d277caea34897278157174cdeda2e22c4f2dd1fa (Fri Oct 16 10:49:05 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12041:
URL: https://github.com/apache/flink/pull/12041#issuecomment-625810298

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit d277caea34897278157174cdeda2e22c4f2dd1fa (Fri May 08 13:15:42 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12041:
URL: https://github.com/apache/flink/pull/12041#issuecomment-625871059


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d277caea34897278157174cdeda2e22c4f2dd1fa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d277caea34897278157174cdeda2e22c4f2dd1fa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d277caea34897278157174cdeda2e22c4f2dd1fa UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org