[GitHub] [knox] zeroflag commented on a change in pull request #537: KNOX-2707 - Virtual Group Mapping Provider

[GitBox <gi...@apache.org>]

zeroflag commented on a change in pull request #537:
URL: https://github.com/apache/knox/pull/537#discussion_r811831331



##########
File path: gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java
##########
@@ -17,12 +17,37 @@
  */
 package org.apache.knox.gateway;
 
+import java.util.Set;
+
 import org.apache.knox.gateway.i18n.messages.Message;
 import org.apache.knox.gateway.i18n.messages.MessageLevel;
 import org.apache.knox.gateway.i18n.messages.Messages;
+import org.apache.knox.gateway.plang.Ast;
+import org.apache.knox.gateway.plang.SyntaxException;
 
 @Messages(logger="org.apache.knox.gateway")
 public interface IdentityAsserterMessages {
   @Message( level = MessageLevel.ERROR, text = "Required subject/identity not available.  Check authentication/federation provider for proper configuration." )
   void subjectNotAvailable();
+
+  @Message( level = MessageLevel.WARN, text = "Virtual group name is missing after dot character.")

Review comment:
       We put the users into these groups based on their LDAP/OS level groups. If we refer both of the virtual groups and LDAP/OS groups simply as groups, it can be confusing, isn't it? I'm not sure what would be the proper naming.
   
   > Is this in reference to param names? If so, perhaps something like "Invalid mapping parameter name: Missing required group name."
   
   Ok. I changed the the message.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org