You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "s7monk (via GitHub)" <gi...@apache.org> on 2023/10/16 03:31:29 UTC

[PR] [Improvement] Improve tablecontroller [incubator-paimon-webui]

s7monk opened a new pull request, #55:
URL: https://github.com/apache/incubator-paimon-webui/pull/55

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   Improve tablecontroller
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Improve server module [incubator-paimon-webui]

Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #55:
URL: https://github.com/apache/incubator-paimon-webui/pull/55#discussion_r1366683556


##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/DatabaseInfo.java:
##########
@@ -32,8 +32,6 @@ public class DatabaseInfo {
 
     private String databaseName;
 
-    private Integer catalogId;

Review Comment:
   > Why remove this id?
   
   catalogId is a useless field here. Paimon's catalog, database, table, etc. do not have id field information. If this change is unnecessary, I will close this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Improve server module [incubator-paimon-webui]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #55:
URL: https://github.com/apache/incubator-paimon-webui/pull/55#discussion_r1365028301


##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/DatabaseInfo.java:
##########
@@ -32,8 +32,6 @@ public class DatabaseInfo {
 
     private String databaseName;
 
-    private Integer catalogId;

Review Comment:
   Why remove this id?



##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/TableController.java:
##########
@@ -269,22 +270,30 @@ private List<TableChange> createTableChanges(TableColumn oldColumn, TableColumn
     /**
      * Adds options to a table.
      *
-     * @param tableInfo An object containing table information.
-     * @return If the options are successfully added, returns a successful result object. If an
-     *     exception occurs, returns a result object with an error status.
+     * @param catalogName the name of the catalog where the database is located.
+     * @param databaseName the name of the database where the table is located.
+     * @param tableName the name of the table to which options are added.
+     * @param options a map of options to add to the table.
+     * @return a response indicating the success or failure of the operation.
      */
     @PostMapping("/option/add")
-    public R<Void> addOption(@RequestBody TableInfo tableInfo) {
+    public R<Void> addOption(

Review Comment:
   Pls revert this change. It's better to use `tableInfo`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement] Improve server module [incubator-paimon-webui]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #55: [Improvement] Improve server module
URL: https://github.com/apache/incubator-paimon-webui/pull/55


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org