[GitHub] [spark] ueshin commented on a diff in pull request #41041: [SPARK-43363][SQL][PYTHON] Remove a workaround for pandas categorical type for pyarrow

["ueshin (via GitHub)" <gi...@apache.org>]

ueshin commented on code in PR #41041:
URL: https://github.com/apache/spark/pull/41041#discussion_r1184526296


##########
python/pyspark/sql/pandas/serializers.py:
##########
@@ -226,9 +225,6 @@ def create_array(s, t):
                 s = _check_series_convert_timestamps_internal(s, self._timezone)
             elif t is not None and pa.types.is_map(t):
                 s = _convert_dict_to_map_items(s)
-            elif is_categorical_dtype(s.dtype):
-                # Note: This can be removed once minimum pyarrow version is >= 0.16.1
-                s = s.astype(s.dtypes.categories.dtype)

Review Comment:
   @BryanCutler Seems like if `t is None`, `pa.Array.from_pandas(s, mask=mask, type=t, safe=self._safecheck)` handles the categorical type as integer (`tinyint` as its code) instead of some type of `s.dtypes.categories.dtype`. Is that an expected behavior?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org