You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/09/26 22:31:27 UTC

[GitHub] [pinot] walterddr commented on a diff in pull request #11688: [multistage] improve dispatch exception handling

walterddr commented on code in PR #11688:
URL: https://github.com/apache/pinot/pull/11688#discussion_r1337844975


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/SubmissionService.java:
##########
@@ -24,29 +24,30 @@
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
+import org.apache.pinot.common.exception.QueryException;
 
 
 /**
  * Submission service is used to submit multiple runnables and checks the result upon all {@link Future} returns
  * or any failure occurs.
  */
 public class SubmissionService {
-  private final ExecutorService _executor;
   private final List<CompletableFuture<Void>> _futures = new ArrayList<>();
 
-  public SubmissionService(ExecutorService executor) {
-    _executor = executor;
+  public SubmissionService() {

Review Comment:
   good point. will convert it into a util --> its only job is to maintain the list of futures for completion 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org