You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/06/27 16:09:45 UTC

[jira] [Created] (BOOKKEEPER-322) New protobufs generates findbugs errors

Ivan Kelly created BOOKKEEPER-322:
-------------------------------------

             Summary: New protobufs generates findbugs errors
                 Key: BOOKKEEPER-322
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-322
             Project: Bookkeeper
          Issue Type: Bug
            Reporter: Ivan Kelly
            Assignee: Ivan Kelly
            Priority: Minor
             Fix For: 4.2.0


We need to exclude the protobuf generated classes from findbugs. Also, the generated sources should be excluded from the apache-rat:check.

Also, there's one other findbug in LedgerMetadata

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-322) New protobufs generates findbugs errors

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403303#comment-13403303 ] 

Hudson commented on BOOKKEEPER-322:
-----------------------------------

Integrated in bookkeeper-trunk #583 (See [https://builds.apache.org/job/bookkeeper-trunk/583/])
    BOOKKEEPER-322: New protobufs generates findbugs errors (ivank) (Revision 1355083)

     Result = SUCCESS
ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/pom.xml
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/resources/findbugsExclude.xml
* /zookeeper/bookkeeper/trunk/hedwig-protocol/pom.xml
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/resources
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/resources/findbugsExclude.xml

                
> New protobufs generates findbugs errors
> ---------------------------------------
>
>                 Key: BOOKKEEPER-322
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-322
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Minor
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-322.diff
>
>
> We need to exclude the protobuf generated classes from findbugs. Also, the generated sources should be excluded from the apache-rat:check.
> Also, there's one other findbug in LedgerMetadata

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (BOOKKEEPER-322) New protobufs generates findbugs errors

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-322:
----------------------------------

    Attachment: BOOKKEEPER-322.diff
    
> New protobufs generates findbugs errors
> ---------------------------------------
>
>                 Key: BOOKKEEPER-322
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-322
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Minor
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-322.diff
>
>
> We need to exclude the protobuf generated classes from findbugs. Also, the generated sources should be excluded from the apache-rat:check.
> Also, there's one other findbug in LedgerMetadata

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-322) New protobufs generates findbugs errors

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403086#comment-13403086 ] 

Sijie Guo commented on BOOKKEEPER-322:
--------------------------------------

the patch looks good. +1.
                
> New protobufs generates findbugs errors
> ---------------------------------------
>
>                 Key: BOOKKEEPER-322
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-322
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Minor
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-322.diff
>
>
> We need to exclude the protobuf generated classes from findbugs. Also, the generated sources should be excluded from the apache-rat:check.
> Also, there's one other findbug in LedgerMetadata

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira