You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 12:11:08 UTC

[GitHub] [flink] aljoscha commented on pull request #12179: [FLINK-16144] get client.timeout for the client, with a fallback to the akka.client…

aljoscha commented on pull request #12179:
URL: https://github.com/apache/flink/pull/12179#issuecomment-630139839


   Hi, thanks for your PR!
   
   We should add a new `ClientOptions` class that keeps the `CLIENT_TIMEOUT` (with a fallback to the old `akka.client.timeout`. Then we can change existing usage of `AkkaUtils.getClientTimeout()` to use the new config, we can then probably remove `AkkaUtils.getClientTimeout()`. Also, for the new option you can use `durationType()` instead of `stringType()`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org