You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "subhasisgorai (via GitHub)" <gi...@apache.org> on 2023/01/31 17:51:06 UTC
[GitHub] [hive] subhasisgorai opened a new pull request, #4003: HIVE-26931: REPL LOAD command does not throw any error for incorrect syntax
subhasisgorai opened a new pull request, #4003:
URL: https://github.com/apache/hive/pull/4003
### What changes were proposed in this pull request?
While performing a REPL LOAD, the source and target database names are made mandatory.
### Why are the changes needed?
The standard REPL LOAD syntax is,
`repl load src into tgt with ( <config properties (if any) >);`
But in some cases, users are using the REPL LOAD command incorrectly. It does not really throw any meaningful error/warning message, and as expected it does not replicate the database as well.
For example,
`repl load target_db with ('hive.repl.rootdir'='hdfs://c3649-node2.coelab.cloudera.com:8020/user/hive/repl', 'hive.repl.include.external.tables'= 'true', 'hive.repl.replica.external.table.base.dir'='hdfs://c3649node2.coelab.cloudera.com:8020/warehouse/tablespace/external/hive/target_db.db')
`
The above command does not follow the REPL LOAD syntax. This does not produce any error message, nor it replicates the database. So, it causes confusion.
### Does this PR introduce _any_ user-facing change?
No, it's more of a validation for the correct REPL LOAD usage.
### How was this patch tested?
Tested manually, and also updated the automated tests to reflect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pudidic commented on pull request #4003: HIVE-26931: REPL LOAD command does not throw any error for incorrect syntax
Posted by "pudidic (via GitHub)" <gi...@apache.org>.
pudidic commented on PR #4003:
URL: https://github.com/apache/hive/pull/4003#issuecomment-1411454095
+1. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pudidic merged pull request #4003: HIVE-26931: REPL LOAD command does not throw any error for incorrect syntax
Posted by "pudidic (via GitHub)" <gi...@apache.org>.
pudidic merged PR #4003:
URL: https://github.com/apache/hive/pull/4003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org