You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/19 08:15:12 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #588: sim: add a
pseudo netdev backed by vpnkit
yamt opened a new pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #588: sim:
add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #588: sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394937684
##########
File path: arch/sim/src/sim/vpnkit/negotiate.c
##########
@@ -0,0 +1,126 @@
+/****************************************************************************
+ * arch/sim/src/sim/vpnkit/negotiate.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * This file is derivative from vpnkit.
+ *
+ * Copyright 2013-2016 Docker, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
Review comment:
change to \r\n
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #588:
sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394978338
##########
File path: arch/sim/Kconfig
##########
@@ -117,15 +117,35 @@ config SIM_NETDEV
select ARCH_HAVE_NETDEV_STATISTICS
select SCHED_LPWORK
select SIM_WALLTIME
+ ---help---
+ Build in support for a simulated network device.
+
+if SIM_NETDEV
+
+choice
+ prompt "Simulated Network Device Type"
+ default SIM_NETDEV_TAP
+
+config SIM_NETDEV_TAP
+ bool "Simulated Network Device with TAP/WPCAP"
---help---
Build in support for a simulated network device using a TAP device on Linux or
WPCAP on Windows.
+config SIM_NETDEV_VPNKIT
+ bool "Simulated Network Device with VPNKit"
Review comment:
will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #588:
sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394986222
##########
File path: arch/sim/src/sim/up_vpnkit.c
##########
@@ -0,0 +1,259 @@
+/****************************************************************************
+ * arch/sim/src/sim/up_vpnkit.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/types.h>
+#include <sys/un.h>
+
+/* XXX broken api: mixing nuttx and host in_addr_t */
+
+#include <netinet/in.h>
+
+#include <poll.h>
+#include <stdio.h>
+#include <string.h>
+#include <unistd.h>
+
+#include "vpnkit/protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define INFO(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define DEBUG(fmt, ...)
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const char *g_vpnkit_socket_path = "/tmp/vpnkit-nuttx"; /* XXX config */
+struct vif_info g_vifinfo;
+int g_vpnkit_fd = -1;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #588:
sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394978521
##########
File path: arch/sim/src/sim/vpnkit/protocol.c
##########
@@ -0,0 +1,324 @@
+/****************************************************************************
+ * arch/sim/src/sim/vpnkit/protocol.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * This file is derivative from vpnkit.
+ *
+ * Copyright 2013-2016 Docker, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/socket.h>
+#include <sys/types.h>
+#include <sys/uio.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <string.h>
+#include <stdio.h>
+
+#include "protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #588: sim: add
a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#issuecomment-601147714
> @xiaoxiang781216
> a few reasons to prefer vpnkit:
>
> * works on macos
> * works without root privilege
It's great if you can add the setup instruction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #588: sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394930273
##########
File path: arch/sim/src/sim/vpnkit/protocol.c
##########
@@ -0,0 +1,324 @@
+/****************************************************************************
+ * arch/sim/src/sim/vpnkit/protocol.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * This file is derivative from vpnkit.
+ *
+ * Copyright 2013-2016 Docker, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/socket.h>
+#include <sys/types.h>
+#include <sys/uio.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <string.h>
+#include <stdio.h>
+
+#include "protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
Review comment:
\n\r to \r\n?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #588: sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394932676
##########
File path: arch/sim/src/sim/up_vpnkit.c
##########
@@ -0,0 +1,259 @@
+/****************************************************************************
+ * arch/sim/src/sim/up_vpnkit.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/types.h>
+#include <sys/un.h>
+
+/* XXX broken api: mixing nuttx and host in_addr_t */
+
+#include <netinet/in.h>
+
+#include <poll.h>
+#include <stdio.h>
+#include <string.h>
+#include <unistd.h>
+
+#include "vpnkit/protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define INFO(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define DEBUG(fmt, ...)
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const char *g_vpnkit_socket_path = "/tmp/vpnkit-nuttx"; /* XXX config */
+struct vif_info g_vifinfo;
+int g_vpnkit_fd = -1;
Review comment:
all can be static?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #588:
sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394978250
##########
File path: arch/sim/src/sim/vpnkit/negotiate.c
##########
@@ -0,0 +1,126 @@
+/****************************************************************************
+ * arch/sim/src/sim/vpnkit/negotiate.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * This file is derivative from vpnkit.
+ *
+ * Copyright 2013-2016 Docker, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #588:
sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394986163
##########
File path: arch/sim/Kconfig
##########
@@ -117,15 +117,35 @@ config SIM_NETDEV
select ARCH_HAVE_NETDEV_STATISTICS
select SCHED_LPWORK
select SIM_WALLTIME
+ ---help---
+ Build in support for a simulated network device.
+
+if SIM_NETDEV
+
+choice
+ prompt "Simulated Network Device Type"
+ default SIM_NETDEV_TAP
+
+config SIM_NETDEV_TAP
+ bool "Simulated Network Device with TAP/WPCAP"
---help---
Build in support for a simulated network device using a TAP device on Linux or
WPCAP on Windows.
+config SIM_NETDEV_VPNKIT
+ bool "Simulated Network Device with VPNKit"
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #588:
sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394978466
##########
File path: arch/sim/src/sim/up_vpnkit.c
##########
@@ -0,0 +1,259 @@
+/****************************************************************************
+ * arch/sim/src/sim/up_vpnkit.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/types.h>
+#include <sys/un.h>
+
+/* XXX broken api: mixing nuttx and host in_addr_t */
+
+#include <netinet/in.h>
+
+#include <poll.h>
+#include <stdio.h>
+#include <string.h>
+#include <unistd.h>
+
+#include "vpnkit/protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define INFO(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define DEBUG(fmt, ...)
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const char *g_vpnkit_socket_path = "/tmp/vpnkit-nuttx"; /* XXX config */
+struct vif_info g_vifinfo;
+int g_vpnkit_fd = -1;
Review comment:
will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #588:
sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394978574
##########
File path: arch/sim/src/sim/up_vpnkit.c
##########
@@ -0,0 +1,259 @@
+/****************************************************************************
+ * arch/sim/src/sim/up_vpnkit.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/types.h>
+#include <sys/un.h>
+
+/* XXX broken api: mixing nuttx and host in_addr_t */
+
+#include <netinet/in.h>
+
+#include <poll.h>
+#include <stdio.h>
+#include <string.h>
+#include <unistd.h>
+
+#include "vpnkit/protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define INFO(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #588: sim: add a pseudo
netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#issuecomment-601140552
@xiaoxiang781216
a few reasons to prefer vpnkit:
* works on macos
* works without root privilege
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #588: sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394927420
##########
File path: arch/sim/src/sim/up_vpnkit.c
##########
@@ -0,0 +1,259 @@
+/****************************************************************************
+ * arch/sim/src/sim/up_vpnkit.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/types.h>
+#include <sys/un.h>
+
+/* XXX broken api: mixing nuttx and host in_addr_t */
+
+#include <netinet/in.h>
+
+#include <poll.h>
+#include <stdio.h>
+#include <string.h>
+#include <unistd.h>
+
+#include "vpnkit/protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define INFO(fmt, ...) \
+ fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
Review comment:
\n\r to \r\n?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #588: sim: add a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394933857
##########
File path: arch/sim/Kconfig
##########
@@ -117,15 +117,35 @@ config SIM_NETDEV
select ARCH_HAVE_NETDEV_STATISTICS
select SCHED_LPWORK
select SIM_WALLTIME
+ ---help---
+ Build in support for a simulated network device.
+
+if SIM_NETDEV
+
+choice
+ prompt "Simulated Network Device Type"
+ default SIM_NETDEV_TAP
+
+config SIM_NETDEV_TAP
+ bool "Simulated Network Device with TAP/WPCAP"
---help---
Build in support for a simulated network device using a TAP device on Linux or
WPCAP on Windows.
+config SIM_NETDEV_VPNKIT
+ bool "Simulated Network Device with VPNKit"
Review comment:
Could you update the related section in:
boards\sim\sim\sim\README.txt
boards\sim\sim\sim\NETWORK-LINUX.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #588: sim: add
a pseudo netdev backed by vpnkit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#issuecomment-601117818
@yamt could you tell me which case should we prefer vpnkit than tap?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services