You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2018/08/07 20:22:25 UTC

[incubator-superset] branch master updated: update python3 version for testing to 3.6 (#5562)

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 39ff9de  update python3 version for testing to 3.6 (#5562)
39ff9de is described below

commit 39ff9deb573fd0d34a2afdcb216092dccca8086b
Author: Octavian <oc...@gmail.com>
AuthorDate: Tue Aug 7 22:22:19 2018 +0200

    update python3 version for testing to 3.6 (#5562)
    
    * update python version for testing to 3.6
    
    * CONTRIBUTING.md states pull requests should work on py27, py36+
    
    * CONTRIBUTING.md states pull requests should work on py27 and py36
---
 CONTRIBUTING.md       | 4 ++--
 docs/installation.rst | 2 +-
 tox.ini               | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 6e20d61..685d1f9 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -65,7 +65,7 @@ meets these guidelines:
 3.  If the pull request adds functionality, the docs should be updated
     as part of the same PR. Doc string are often sufficient, make
     sure to follow the sphinx compatible standards.
-4.  The pull request should work for Python 2.7, and ideally Python 3.4+.
+4.  The pull request should work for Python 2.7 and Python 3.6.
     ``from __future__ import`` will be required in every `.py` file soon.
 5.  If the pull request adds a Python dependency include it in `setup.py`
     denoting any specific restrictions and in `requirements.txt` pinned to a
@@ -291,7 +291,7 @@ All python tests can be run with any of the tox [environments](http://tox.readth
 i.e.,
 
     tox -e py27
-    tox -e py34
+    tox -e py36
 
 Alternatively, you can run all tests in a single file via,
 
diff --git a/docs/installation.rst b/docs/installation.rst
index da6c8c4..ce97dbd 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -4,7 +4,7 @@ Installation & Configuration
 Getting Started
 ---------------
 
-Superset is tested against Python ``2.7`` and Python ``3.4``.
+Superset is tested against Python ``2.7`` and Python ``3.6``.
 Airbnb currently uses 2.7.* in production. We do not plan on supporting
 Python ``2.6``.
 
diff --git a/tox.ini b/tox.ini
index 06015d7..b73d276 100644
--- a/tox.ini
+++ b/tox.ini
@@ -37,9 +37,9 @@ setenv =
     SUPERSET_CONFIG = tests.superset_test_config
     SUPERSET_HOME = {envtmpdir}
     py27-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset?charset=utf8
-    py{34,36}-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset
-    py{27,34,36}-postgres: SUPERSET__SQLALCHEMY_DATABASE_URI = postgresql+psycopg2://postgresuser:pguserpassword@localhost/superset
-    py{27,34,36}-sqlite: SUPERSET__SQLALCHEMY_DATABASE_URI = sqlite:////{envtmpdir}/superset.db
+    py36-mysql: SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset
+    py{27,36}-postgres: SUPERSET__SQLALCHEMY_DATABASE_URI = postgresql+psycopg2://postgresuser:pguserpassword@localhost/superset
+    py{27,36}-sqlite: SUPERSET__SQLALCHEMY_DATABASE_URI = sqlite:////{envtmpdir}/superset.db
 whitelist_externals =
     npm