You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "wenbingshen (via GitHub)" <gi...@apache.org> on 2023/03/02 12:40:09 UTC
[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3833: [improve] Enhance LedgerFragment toString method
wenbingshen opened a new pull request, #3833:
URL: https://github.com/apache/bookkeeper/pull/3833
### Motivation
LedgerFragment adds the state of replicateType, but it has not been added to the toString method. I think the replicateType should be added to the toString method to track the state of LF and troubleshoot problems.
### Changes
LedgerFragment is generally in `DATA_LOSS` or `DATA_NOT_ADHERING_PLACEMENT` state.
But it shouldn't have status when it's in detection progress or used elsewhere, so I added `NULL` status.
The following log shows the result:
replicating DATA_LOSS LedgerFragment
replicating DATA_NOT_ADHERING_PLACEMENT LedgerFragment
checking LedgerFragment in NULL type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen closed pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen closed pull request #3833: [improve] Enhance LedgerFragment toString method
URL: https://github.com/apache/bookkeeper/pull/3833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on code in PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#discussion_r1184559648
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java:
##########
@@ -229,15 +229,16 @@ public void setReplicateType(ReplicateType replicateType) {
@Override
public String toString() {
return String.format("Fragment(LedgerID: %d, FirstEntryID: %d[%d], "
- + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s)", ledgerId, firstEntryId,
+ + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s, Type: %s)", ledgerId, firstEntryId,
getFirstStoredEntryId(), lastKnownEntryId, getLastStoredEntryId(),
- getAddresses(), isLedgerClosed);
+ getAddresses(), isLedgerClosed, replicateType);
}
/**
* ReplicateType.
*/
public enum ReplicateType {
+ NULL,
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#issuecomment-1455569591
@horizonzy @hangc0276 @zymap Could you help take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on code in PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#discussion_r1184648942
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java:
##########
@@ -229,15 +229,16 @@ public void setReplicateType(ReplicateType replicateType) {
@Override
public String toString() {
return String.format("Fragment(LedgerID: %d, FirstEntryID: %d[%d], "
- + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s)", ledgerId, firstEntryId,
+ + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s, Type: %s)", ledgerId, firstEntryId,
getFirstStoredEntryId(), lastKnownEntryId, getLastStoredEntryId(),
- getAddresses(), isLedgerClosed);
+ getAddresses(), isLedgerClosed, replicateType);
}
/**
* ReplicateType.
*/
public enum ReplicateType {
+ NULL,
Review Comment:
In my opinion, the replicateType doesn't represent the state; it only records the use of the LedgerFragment.
The default value is data_loss, because the data_loss priority is the highest. The ledger may be data_loss and not adhere to the placement policy at the same time, we fix the data_loss case firstly.
After the replicationWorker moves the data to a new bookie, the new bookie may be a different rack bookie. It will cover the not adhering to the placement policy case.
> AuditorCheckAllLedgersTask and ReplicationWorker use LedgerChecker checkLedger. By default, it will check the first and last Entry of each LedgerFragment of the ledger before the check is completed.
In this case, it only checks if the ledger data is loss or not, the replicationType should be DATA_LOSS.
In AuditorPlacementPolicyCheckTask, it will check if the ledger ensemble adheres to the placement policy or not. If so, mark the ledger unreplicated. It didn't use LedgerChecker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on code in PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#discussion_r1184523292
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java:
##########
@@ -229,15 +229,16 @@ public void setReplicateType(ReplicateType replicateType) {
@Override
public String toString() {
return String.format("Fragment(LedgerID: %d, FirstEntryID: %d[%d], "
- + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s)", ledgerId, firstEntryId,
+ + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s, Type: %s)", ledgerId, firstEntryId,
getFirstStoredEntryId(), lastKnownEntryId, getLastStoredEntryId(),
- getAddresses(), isLedgerClosed);
+ getAddresses(), isLedgerClosed, replicateType);
}
/**
* ReplicateType.
*/
public enum ReplicateType {
+ NULL,
Review Comment:
Would you please explain why adding the `NULL` state and what's the meaning of the `NULL` replication type? I found the all code parts are related to `DATA_LOSS` or `DATA_NOT_ADHERING_PLACEMENT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on code in PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#discussion_r1184648942
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java:
##########
@@ -229,15 +229,16 @@ public void setReplicateType(ReplicateType replicateType) {
@Override
public String toString() {
return String.format("Fragment(LedgerID: %d, FirstEntryID: %d[%d], "
- + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s)", ledgerId, firstEntryId,
+ + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s, Type: %s)", ledgerId, firstEntryId,
getFirstStoredEntryId(), lastKnownEntryId, getLastStoredEntryId(),
- getAddresses(), isLedgerClosed);
+ getAddresses(), isLedgerClosed, replicateType);
}
/**
* ReplicateType.
*/
public enum ReplicateType {
+ NULL,
Review Comment:
In my opinion, the replicateType doesn't represent the state; it only records the use of the LedgerFragment.
The default value is data_loss, because the data_loss priority is the highest. The ledger may be data_loss and not adhere to the placement policy at the same time, we fix the data_loss case firstly, it may cover the not adhere to the placement policy case.
> AuditorCheckAllLedgersTask and ReplicationWorker use LedgerChecker checkLedger. By default, it will check the first and last Entry of each LedgerFragment of the ledger before the check is completed.
In this case, it only checks if the ledger data is loss or not, the replicationType should be DATA_LOSS.
In AuditorPlacementPolicyCheckTask, it will check if the ledger ensemble adheres to the placement policy or not. If so, mark the ledger unreplicated. It didn't use LedgerChecker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT merged pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT merged PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#issuecomment-1534617857
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#issuecomment-1535625943
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#issuecomment-1534073257
@horizonzy Please help take a look, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on a diff in pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on code in PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#discussion_r1184799465
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java:
##########
@@ -229,15 +229,16 @@ public void setReplicateType(ReplicateType replicateType) {
@Override
public String toString() {
return String.format("Fragment(LedgerID: %d, FirstEntryID: %d[%d], "
- + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s)", ledgerId, firstEntryId,
+ + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s, Type: %s)", ledgerId, firstEntryId,
getFirstStoredEntryId(), lastKnownEntryId, getLastStoredEntryId(),
- getAddresses(), isLedgerClosed);
+ getAddresses(), isLedgerClosed, replicateType);
}
/**
* ReplicateType.
*/
public enum ReplicateType {
+ NULL,
Review Comment:
@horizonzy I understand what you mean enough now, I misunderstood earlier, I understood replicateType as a piecemeal state, as you said, it does not represent state.
Now I want to add replicateType to the toString method of LedgerFragment. When the user opens the debug logger, we can see this situation:
When checking a fragment, the fragment replicateType is DATA_LOSS, which may be a bit strange for users.
This is only a small ambiguity here, but I think it is not a big problem now, we keep DATA_LOSS and DATA_NOT_ADHERING_PLACEMENT enough, it does not affect the result of program execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on a diff in pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "wenbingshen (via GitHub)" <gi...@apache.org>.
wenbingshen commented on code in PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#discussion_r1184622195
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragment.java:
##########
@@ -229,15 +229,16 @@ public void setReplicateType(ReplicateType replicateType) {
@Override
public String toString() {
return String.format("Fragment(LedgerID: %d, FirstEntryID: %d[%d], "
- + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s)", ledgerId, firstEntryId,
+ + "LastKnownEntryID: %d[%d], Host: %s, Closed: %s, Type: %s)", ledgerId, firstEntryId,
getFirstStoredEntryId(), lastKnownEntryId, getLastStoredEntryId(),
- getAddresses(), isLedgerClosed);
+ getAddresses(), isLedgerClosed, replicateType);
}
/**
* ReplicateType.
*/
public enum ReplicateType {
+ NULL,
Review Comment:
@hangc0276 @horizonzy Yes, when I first looked at the use of LedgerFragment, I also thought it only had two states, `DATA_LOSS` or `DATA_NOT_ADHERING_PLACEMENT`, when I read the code again, I felt something was different.
`LedgerFragmentReplicator` is used to copy and restore those copies of a ledger segment in a failed bookie. This state initialization is `DATA_LOSS`.
`ReplicationWorker` will first recover the LedgerFragment of `DATA_LOSS` state, and then recover the LedgerFragment of `DATA_NOT_ADHERING_PLACEMENT`.
When `BookKeeperAdmin` is recovering Ledger, LedgerFragment is in `DATA_LOSS` state.
The above LedgerFragment is mainly in recover or replicate, and LedgerFragment has an obvious state.
In addition to the above, there is also a LedgerFragment, which is in an unclear state and mainly occurs inside `LedgerChecker`. `AuditorCheckAllLedgersTask` and `ReplicationWorker` use `LedgerChecker` checkLedger. By default, it will check the first and last Entry of each LedgerFragment of the ledger before the check is completed. , LedgerFragment should not be in `DATA_LOSS` or `DATA_NOT_ADHERING_PLACEMENT`, because after the inspection is completed, the LedgerFragment may be normal, or the replicate may be missing; before and after the inspection is completed, we sometimes print the LedgerFragment through debug, which may cause a wrong state, so I added the `NULL` state is used to identify this situation.
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerChecker.java#L476-L492
```java
for (LedgerFragment r : fragments) {
if (LOG.isDebugEnabled()) {
LOG.debug("Checking fragment {}", r);
}
try {
verifyLedgerFragment(r, allFragmentsCb, percentageOfLedgerFragmentToBeVerified);
} catch (InvalidFragmentException ife) {
LOG.error("Invalid fragment found : {}", r);
allFragmentsCb.operationComplete(
BKException.Code.IncorrectParameterException, r);
} catch (BKException e) {
LOG.error("BKException when checking fragment : {}", r, e);
} catch (InterruptedException e) {
LOG.error("InterruptedException when checking fragment : {}", r, e);
}
}
```
`NULL` may be difficult to understand, maybe we can add `INIT` before checking, and `NORMAL` state if the segment not data loss after checking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3833: [improve] Enhance LedgerFragment toString method
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3833:
URL: https://github.com/apache/bookkeeper/pull/3833#issuecomment-1455501217
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3833](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b69d198) into [master](https://codecov.io/gh/apache/bookkeeper/commit/128c52eeffeb0d009aedc3b92e8bd30852332a09?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (128c52e) will **decrease** coverage by `39.48%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3833 +/- ##
=============================================
- Coverage 60.40% 20.93% -39.48%
+ Complexity 5856 2016 -3840
=============================================
Files 473 473
Lines 40906 40909 +3
Branches 5232 5232
=============================================
- Hits 24711 8563 -16148
- Misses 13981 31083 +17102
+ Partials 2214 1263 -951
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `?` | |
| remaining | `?` | |
| replication | `?` | |
| tls | `20.93% <0.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/bookkeeper/client/BookKeeperAdmin.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0Jvb2tLZWVwZXJBZG1pbi5qYXZh) | `1.99% <0.00%> (-31.30%)` | :arrow_down: |
| [...va/org/apache/bookkeeper/client/LedgerChecker.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0xlZGdlckNoZWNrZXIuamF2YQ==) | `0.00% <0.00%> (-75.25%)` | :arrow_down: |
| [...a/org/apache/bookkeeper/client/LedgerFragment.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0xlZGdlckZyYWdtZW50LmphdmE=) | `0.00% <0.00%> (-90.79%)` | :arrow_down: |
| [.../java/org/apache/bookkeeper/util/SubTreeCache.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdXRpbC9TdWJUcmVlQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/bookkeeper/proto/BookieClient.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vQm9va2llQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...org/apache/bookkeeper/bookie/ReadOnlyFileInfo.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL1JlYWRPbmx5RmlsZUluZm8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...org/apache/bookkeeper/bookie/datainteg/Events.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL2RhdGFpbnRlZy9FdmVudHMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rg/apache/bookkeeper/client/api/CreateBuilder.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L2FwaS9DcmVhdGVCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rg/apache/bookkeeper/metastore/MetastoreTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/bookkeeper/bookie/storage/EntryLogger.java](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvRW50cnlMb2dnZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [341 more](https://codecov.io/gh/apache/bookkeeper/pull/3833?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org