You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/18 17:07:46 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #17688: Chart: fix running with uid 0
jedcunningham opened a new pull request #17688:
URL: https://github.com/apache/airflow/pull/17688
This fixes running the chart with uid 0:
```
helm upgrade --install --set uid=0 test airflow/airflow
```
Closes: #17679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17688: Chart: fix running with uid 0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17688:
URL: https://github.com/apache/airflow/pull/17688#issuecomment-901288565
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17688: Chart: fix running with uid 0
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17688:
URL: https://github.com/apache/airflow/pull/17688#discussion_r691512970
##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -144,6 +144,7 @@ spec:
periodSeconds: {{ .Values.scheduler.livenessProbe.periodSeconds }}
exec:
command:
+ - /entrypoint
Review comment:
Mainly those documented here: https://airflow.apache.org/docs/docker-stack/entrypoint.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17688: Chart: fix running with uid 0
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17688:
URL: https://github.com/apache/airflow/pull/17688#discussion_r691448053
##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -144,6 +144,7 @@ spec:
periodSeconds: {{ .Values.scheduler.livenessProbe.periodSeconds }}
exec:
command:
+ - /entrypoint
Review comment:
Any concerns with this breaking compatibility with other images, not the official image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17688: Chart: fix running with uid 0
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17688:
URL: https://github.com/apache/airflow/pull/17688#discussion_r691453217
##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -144,6 +144,7 @@ spec:
periodSeconds: {{ .Values.scheduler.livenessProbe.periodSeconds }}
exec:
command:
+ - /entrypoint
Review comment:
Do we have any other :) ? I think we already make many assumptions about the image, so one more does not hurt. Maybe add parameter to override the entrypoint if needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17688: Chart: fix running with uid 0
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17688:
URL: https://github.com/apache/airflow/pull/17688#discussion_r691490786
##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -144,6 +144,7 @@ spec:
periodSeconds: {{ .Values.scheduler.livenessProbe.periodSeconds }}
exec:
command:
+ - /entrypoint
Review comment:
Yeah, that's how I was leaning as well 👍.
(Maybe I'll try using a custom image one of these days and see what those assumptions are)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17688: Chart: fix running with uid 0
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17688:
URL: https://github.com/apache/airflow/pull/17688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17688: Chart: fix running with uid 0
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17688:
URL: https://github.com/apache/airflow/pull/17688#discussion_r691448053
##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -144,6 +144,7 @@ spec:
periodSeconds: {{ .Values.scheduler.livenessProbe.periodSeconds }}
exec:
command:
+ - /entrypoint
Review comment:
Any concerns with this breaking compatibility with other images (e.g. not the official image)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org