You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2013/11/08 10:20:10 UTC

svn commit: r1539956 - /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java

Author: kkolinko
Date: Fri Nov  8 09:20:10 2013
New Revision: 1539956

URL: http://svn.apache.org/r1539956
Log:
https://issues.apache.org/jira/browse/MTOMCAT-211
Followup to r1539920
Introduce a local variable to cache the object created by expandFile.getParentFile() call.

Modified:
    tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java

Modified: tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java
URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java?rev=1539956&r1=1539955&r2=1539956&view=diff
==============================================================================
--- tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java (original)
+++ tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java Fri Nov  8 09:20:10 2013
@@ -580,10 +580,10 @@ public class Tomcat7Runner
                 debugMessage( "expand to file:" + expandFile.getPath() );
 
                 // MTOMCAT-211 ensure parent directories created
-
-                if ( !expandFile.getParentFile().mkdirs() && !expandFile.getParentFile().isDirectory())
+                File parentFile = expandFile.getParentFile();
+                if ( !parentFile.mkdirs() && !parentFile.isDirectory())
                 {
-                    throw new Exception( "FATAL: impossible to create directories:" + expandFile.getParentFile() );
+                    throw new Exception( "FATAL: impossible to create directories:" + parentFile );
                 }
 
                 expand( inputStream, expandFile );



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org