You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/06/21 15:42:07 UTC

[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #830: feat(python/adbc_driver_flightsql): add cookie middleware option to DatabaseOptions

lidavidm commented on code in PR #830:
URL: https://github.com/apache/arrow-adbc/pull/830#discussion_r1237218768


##########
python/adbc_driver_flightsql/adbc_driver_flightsql/__init__.py:
##########
@@ -70,6 +70,8 @@ class DatabaseOptions(enum.Enum):
     WITH_BLOCK = "adbc.flight.sql.client_option.with_block"
     #: Set the maximum gRPC message size (in bytes). The default is 16 MiB.
     WITH_MAX_MSG_SIZE = "adbc.flight.sql.client_option.with_max_msg_size"
+    #: Enable cookie middleware. Default is disabled ("false")
+    WITH_COOKIE_MIDDLEWARE = "adbc.flight.sql.rpc.with_cookie_middleware"

Review Comment:
   Can we keep the options alphabetized?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org