You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/10/01 00:10:54 UTC
[kudu-CR] [util] shorten names for key/mapped types
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4584
Change subject: [util] shorten names for key/mapped types
......................................................................
[util] shorten names for key/mapped types
There are not functional changes in this change.
Change-Id: I9126f9b9a4a2e227ded842eee85140f81051fba6
---
M src/kudu/gutil/map-util.h
1 file changed, 75 insertions(+), 75 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/4584/1
--
To view, visit http://gerrit.cloudera.org:8080/4584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9126f9b9a4a2e227ded842eee85140f81051fba6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] shorten names for key/mapped types
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [util] shorten names for key/mapped types
......................................................................
[util] shorten names for key/mapped types
There are not functional changes in this change.
Change-Id: I9126f9b9a4a2e227ded842eee85140f81051fba6
Reviewed-on: http://gerrit.cloudera.org:8080/4584
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/gutil/map-util.h
1 file changed, 75 insertions(+), 75 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9126f9b9a4a2e227ded842eee85140f81051fba6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [util] shorten names for key/mapped types
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] shorten names for key/mapped types
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4584/1/src/kudu/gutil/map-util.h
File src/kudu/gutil/map-util.h:
PS1, Line 35: // A note on terminology:
: //
: // Map-like containers are collections of pairs. Like all STL containers they
: // contain a few standard typedefs identifying the types of data they contain.
: // Given the following map declaration:
: //
: // map<string, int> my_map;
: //
: // the notable typedefs would be as follows:
: //
: // - key_type -- string
: // - value_type -- pair<const string, int>
: // - mapped_type -- int
: //
: // Note that the map above contains two types of "values": the key-value pairs
: // themselves (value_type) and the values within the key-value pairs
: // (mapped_type). A value_type consists of a key_type and a mapped_type.
: //
: // The documentation below is written for programmers thinking in terms of keys
: // and the (mapped_type) values associated with a given key. For example, the
: // statement
> Does this need to be updated?
As I can see, this piece contains valid and actual information. I could not see longer typenames here like value_type::first_type or value_type::second_type. So, I'd leave it as is if there aren't objections.
--
To view, visit http://gerrit.cloudera.org:8080/4584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9126f9b9a4a2e227ded842eee85140f81051fba6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] [util] shorten names for key/mapped types
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [util] shorten names for key/mapped types
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4584/1/src/kudu/gutil/map-util.h
File src/kudu/gutil/map-util.h:
PS1, Line 35: // A note on terminology:
: //
: // Map-like containers are collections of pairs. Like all STL containers they
: // contain a few standard typedefs identifying the types of data they contain.
: // Given the following map declaration:
: //
: // map<string, int> my_map;
: //
: // the notable typedefs would be as follows:
: //
: // - key_type -- string
: // - value_type -- pair<const string, int>
: // - mapped_type -- int
: //
: // Note that the map above contains two types of "values": the key-value pairs
: // themselves (value_type) and the values within the key-value pairs
: // (mapped_type). A value_type consists of a key_type and a mapped_type.
: //
: // The documentation below is written for programmers thinking in terms of keys
: // and the (mapped_type) values associated with a given key. For example, the
: // statement
Does this need to be updated?
--
To view, visit http://gerrit.cloudera.org:8080/4584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9126f9b9a4a2e227ded842eee85140f81051fba6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes