You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2026/04/16 10:41:27 UTC
[PR] Remove implicit JUnit4 dependency from LogCapturingExtension [pekko]
He-Pin opened a new pull request, #2865:
URL: https://github.com/apache/pekko/pull/2865
## Summary
Fixes #2864
`LogCapturingExtension` is a JUnit 5 `InvocationInterceptor`, but it used `classOf[LogCapturing]` to initialize its logger. Since both classes are in the same package (`javadsl`), this resolves to `javadsl.LogCapturing` — which is the JUnit 4 `TestRule` class. This forces pure JUnit 5 users to also include JUnit 4 on their classpath.
## Changes
- Changed `classOf[LogCapturing]` to `classOf[LogCapturingExtension]` in `LogCapturingExtension.scala` line 27
- This removes the implicit JUnit 4 class reference from the JUnit 5 extension
## Testing
- [x] Code formatted with scalafmt
- [ ] Full CI tests pending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove implicit JUnit4 dependency from LogCapturingExtension [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #2865:
URL: https://github.com/apache/pekko/pull/2865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org