You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2018/05/04 10:12:44 UTC

[GitHub] spark pull request #21155: SPARK-23927: Add "sequence" expression

Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21155#discussion_r186028360
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
    @@ -536,6 +536,15 @@ object TypeCoercion {
               case None => c
             }
     
    +      case s @ Sequence(_, _, _, timeZoneId) if !haveSameType(s.children) =>
    +        val types = s.children.map(_.dataType)
    +        findWiderCommonType(types) match {
    --- End diff --
    
    What if step is interval?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org