You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/07 00:38:07 UTC
[GitHub] [incubator-dolphinscheduler] Yeleights opened a new pull request
#1737: add null check in SubProcessTaskExecThread
Yeleights opened a new pull request #1737: add null check in SubProcessTaskExecThread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1737
## What is the purpose of the pull request
*add null check in SubProcessTaskExecThread*
## Brief change log
- *Edit api/service/ResourcesService*
- *Edit master/runner/SubProcessTaskExecThread*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in
pull request #1737: add null check in SubProcessTaskExecThread
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1737: add null check in SubProcessTaskExecThread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1737#discussion_r363564370
##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/SubProcessTaskExecThread.java
##########
@@ -82,8 +82,10 @@ public Boolean submitWaitComplete() {
}catch (Exception e){
logger.error("exception: "+ e.getMessage(),e);
Review comment:
remove "+ e.getMessage()"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1737:
add null check in SubProcessTaskExecThread
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1737: add null check in SubProcessTaskExecThread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1737#issuecomment-571406825
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737?src=pr&el=h1) Report
> Merging [#1737](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/0628aec535359d3b7f67175fb797c8c2902c8d00?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1737 +/- ##
==========================================
- Coverage 20.13% 20.12% -0.02%
==========================================
Files 285 285
Lines 13935 13934 -1
Branches 2282 2281 -1
==========================================
- Hits 2806 2804 -2
- Misses 10817 10818 +1
Partials 312 312
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...server/master/runner/SubProcessTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvU3ViUHJvY2Vzc1Rhc2tFeGVjVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `79.85% <75%> (-0.1%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737?src=pr&el=footer). Last update [0628aec...ef52278](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Yeleights commented on a change in
pull request #1737: add null check in SubProcessTaskExecThread
Posted by GitBox <gi...@apache.org>.
Yeleights commented on a change in pull request #1737: add null check in SubProcessTaskExecThread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1737#discussion_r363568729
##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/SubProcessTaskExecThread.java
##########
@@ -82,8 +82,10 @@ public Boolean submitWaitComplete() {
}catch (Exception e){
logger.error("exception: "+ e.getMessage(),e);
Review comment:
ok~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1737:
add null check in SubProcessTaskExecThread
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1737: add null check in SubProcessTaskExecThread
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services