You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tmagrino <gi...@git.apache.org> on 2016/08/01 18:35:34 UTC
[GitHub] spark pull request #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops ...
GitHub user tmagrino opened a pull request:
https://github.com/apache/spark/pull/14441
[SPARK-16837] [SQL] TimeWindow incorrectly drops slideDuration in constructors
## What changes were proposed in this pull request?
Fix of incorrect arguments (dropping slideDuration and using windowDuration) in constructors for TimeWindow.
The JIRA this addresses is here: https://issues.apache.org/jira/browse/SPARK-16837
## How was this patch tested?
Added a test to TimeWindowSuite to check that the results of TimeWindow object apply and TimeWindow class constructor are equivalent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tmagrino/spark windowing-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14441
----
commit 9835eb337398deedfdb9ef455554a1fdef45eee1
Author: Tom Magrino <tm...@fb.com>
Date: 2016-08-01T17:44:03Z
Quick fix of incorrect argument in TimeWindow constructors.
commit e1450f8e972ae50c05bed338d527ff3158c114a9
Author: Tom Magrino <tm...@fb.com>
Date: 2016-08-01T18:29:33Z
Added a test to check that TimeWindow object apply is equivalent to the
TimeWindow class constructors.
commit 0e0136a248b483893dcc545c8d7b7a6e91a8c027
Author: Tom Magrino <tm...@fb.com>
Date: 2016-08-01T18:33:37Z
Cleaning up unnecessary changes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by tmagrino <gi...@git.apache.org>.
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/14441
CCing @srowen, @brkyvz, and @sameeragarwal, who appear to have authored a good deal of the TimeWindow code, for comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14441
**[Test build #63090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63090/consoleFull)** for PR 14441 at commit [`0e0136a`](https://github.com/apache/spark/commit/0e0136a248b483893dcc545c8d7b7a6e91a8c027).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63090/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14441
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by sameeragarwal <gi...@git.apache.org>.
Github user sameeragarwal commented on the issue:
https://github.com/apache/spark/pull/14441
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14441
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14441
Merged to master/2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by brkyvz <gi...@git.apache.org>.
Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/14441
oh wow. oops. Thanks for the fix. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14441
**[Test build #63090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63090/consoleFull)** for PR 14441 at commit [`0e0136a`](https://github.com/apache/spark/commit/0e0136a248b483893dcc545c8d7b7a6e91a8c027).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14441: [SPARK-16837] [SQL] TimeWindow incorrectly drops slideDu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14441
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org