[jira] [Commented] (HADOOP-9263) findbugs reports extra warnings on branch-1

["Chris Nauroth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566704#comment-13566704 ] 

Chris Nauroth commented on HADOOP-9263:
---------------------------------------

The easiest way to see the problem is to run ant test-patch with a no-op (empty) patch file:

touch /tmp/empty && ant -Dforrest.home=/Users/chris/apache-forrest-0.9 -Dfindbugs.home=/Users/chris/findbugs-1.3.9 -Dpatch.file=/tmp/empty test-patch

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 14 new Findbugs (version 1.3.9) warnings.

                
> findbugs reports extra warnings on branch-1
> -------------------------------------------
>
>                 Key: HADOOP-9263
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9263
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.1.2
>            Reporter: Chris Nauroth
>
> Currently on branch-1, src/test/test-patch.properties defines {{OK_FINDBUGS_WARNINGS=211}}, but findbugs actually finds 225 warnings.  This means that any patch will get -1 from ant test-patch due to 14 new findbugs warnings, even though the warnings are unrelated to that patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira