You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Szilard Nemeth (JIRA)" <ji...@apache.org> on 2018/08/12 20:10:00 UTC

[jira] [Commented] (YARN-8621) Add REST API tests for Resource Types fields for the apps/ endpoint

    [ https://issues.apache.org/jira/browse/YARN-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577710#comment-16577710 ] 

Szilard Nemeth commented on YARN-8621:
--------------------------------------

By checking the latest code: AppAttempt has no field in the response that would refer to resource requests, see: https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppAttemptInfo.java

Uploaded patch for testing the apps/<appid> endpoint only.
I would create a separate jira that would implement adding a new field to AppAttempt, as it's a whole different story than this one.

[~templedf]: Do you agree creating a follow-up jira that would add the resource request field to the App Attempt and add testcases at the same time? 
Is it required to have those fields in the response at all? 

[~leftnoteasy]: You might be also interested in the question above as you implemented YARN-7817 earlier this year.

Also, code review would be appreciated.

Thanks!

> Add REST API tests for Resource Types fields for the apps/<appId> endpoint
> --------------------------------------------------------------------------
>
>                 Key: YARN-8621
>                 URL: https://issues.apache.org/jira/browse/YARN-8621
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-8621.001.patch
>
>
> This is a complement for YARN-7451 that already added unit tests for the apps and scheduler endpoints.
> The following API endpoints should be tested as well:
> /ws/v1/cluster/apps/<appid>
> -/ws/v1/cluster/apps/<appid>/appattempts-
> -/ws/v1/cluster/apps/<appid>/appattempts/<attemptid>-



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org