You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/10/03 17:39:23 UTC
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/217
Change mvn groupId from io.brooklyn to org.apache.brooklyn
There are some references to io.brooklyn. Try searching the code-base for the regular expresion `maven.*io.brooklyn`. It includes things like `BrooklynNode` referencing `http://search.maven.org/remotecontent?filepath=io/brooklyn/brooklyn-dist/${version}/brooklyn-dist-${version}-dist.tar.gz` to get its install artefacts. In that case, we'd need to add something that checks the version number, or more likely say it can only install apache brooklyn official releases once those are available.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn refactor/change-maven-group-id
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 09fb11e6e8c403b393523a064108cba9ed678091
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-03T15:35:30Z
Change mvn groupId from io.brooklyn to org.apache.brooklyn
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/217#issuecomment-58436194
Rebased against latest master (which will kick off jenkins again).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/217#issuecomment-58443340
Test failure is:
testDuplicateBundle(brooklyn.management.osgi.OsgiStandaloneTest) Time elapsed: 0.491 sec <<< FAILURE!
java.lang.IllegalStateException: test resources not available; may be an IDE issue, so try a mvn rebuild of this project
at brooklyn.util.ResourceUtils.getResourceViaHttp(ResourceUtils.java:430)
at brooklyn.util.ResourceUtils.getResourceFromUrl(ResourceUtils.java:241)
at brooklyn.util.osgi.Osgis.getUrlStream(Osgis.java:389)
at brooklyn.util.osgi.Osgis.cacheFile(Osgis.java:349)
at brooklyn.util.osgi.Osgis.install(Osgis.java:322)
at brooklyn.management.osgi.OsgiStandaloneTest.install(OsgiStandaloneTest.java:100)
at brooklyn.management.osgi.OsgiStandaloneTest.helperDuplicateBundle(OsgiStandaloneTest.java:134)
at brooklyn.management.osgi.OsgiStandaloneTest.testDuplicateBundle(OsgiStandaloneTest.java:122)
I'll look at that tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/217#issuecomment-58507986
@neykov can you take a look at this test failure please? The maven group id has been changed to `org.apache.brooklyn`. The `OsgiStandaloneTest` has been updated accordingly (https://github.com/apache/incubator-brooklyn/pull/217/files#diff-6).
I wonder if it's a chicken and egg problem on the jenkins machine, where that maven artifact won't appear locally until a build can complete - but the build can't complete because the test fails.
However, I wouldn't have thought so because `brooklyn-api` should already have been built by this point (and thus be in `.m2/repository/org/apache/brooklyn/brooklyn-api/0.7.0-SNAPSHOT`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/217#issuecomment-58647971
Now that apache jenkins is happy, I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/217#issuecomment-57815656
Please hold off merging this until we have done one last `io.brooklyn` build of `0.7.0-SNAPSHOT`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/217#issuecomment-58512157
@aledsage Jenkins creates a new local repository for each build which is in a temporary location. Our code looks into System.getProperty("user.home")+"/.m2/repository/" instead. That would explain why it doesn't find the already installed brooklyn-api artefact. And the existing jenkins builds don't fail because they fallback to Sonatype for downloading it where a io.brooklyn SNAPSHOT already exists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/217#issuecomment-58435254
We now have a good snapshot build in sonatype (e.g. https://oss.sonatype.org/content/repositories/snapshots/io/brooklyn/brooklyn-dist/0.7.0-SNAPSHOT/brooklyn-dist-0.7.0-20141008.182833-182-dist.tar.gz), including brooklyn-downstream-parent that was previously missing.
See http://brooklyn.builds.cloudsoftcorp.com/job/Brooklyn-Master-Deploy-Sonatype/205/
Therefore this is ready to merge, once apache jenkins confirms it is ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change mvn groupId from io.brookl...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/217#issuecomment-58347923
There is now a snapshot build, so we are ready to merge (once apache jenkins confirms it's ok):https://oss.sonatype.org/content/repositories/snapshots/io/brooklyn/brooklyn-dist/0.7.0-SNAPSHOT/brooklyn-dist-0.7.0-20141006.175135-180-dist.tar.gz
I've rebased against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---