[jira] Updated: (MYFACES-272) MyFaces unnecessary encodes all non-latin characters as numeric character references even if response character encoding is set to UTF-8

["Kalle Korhonen (JIRA)" <my...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/MYFACES-272?page=all ]

Kalle Korhonen updated MYFACES-272:
-----------------------------------

    Attachment: myfaces-272-conditionallyEncodeChars.patch

Patch created against the latest code from SVN.
I generally don't like the quality of code in HtmlResponseWriter. There's a lot of duplicate code that could be refactored to something more maintainable. However, I didn't try to refactor it now but only made changes to conditionally encode characters as numeric character references. I don't think I made it any worse by doing so. Tested with response set to latin-1 and UTF-8, with basic ASCII, latin-1 and non-latin-1 characters

> MyFaces unnecessary encodes all non-latin characters as numeric character references even if response character encoding is set to UTF-8
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: MYFACES-272
>          URL: http://issues.apache.org/jira/browse/MYFACES-272
>      Project: MyFaces
>         Type: Improvement
>     Versions: Nightly Build
>     Reporter: Kalle Korhonen
>  Attachments: myfaces-272-conditionallyEncodeChars.patch
>
> Encoding all non-latin characters is unnecessary if the response specifies UTF-8 as character encoding and causes a major performance hit. Will provide a patch to do this only when UTF-8 is not used as encoding.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira