You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2010/12/01 13:31:47 UTC

svn commit: r1040980 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

Author: jcompagner
Date: Wed Dec  1 12:31:47 2010
New Revision: 1040980

URL: http://svn.apache.org/viewvc?rev=1040980&view=rev
Log:
fix form previous commit: 1031432
AjaxRequestTarget was not calling IHeaderResponse.close() after traversing hierarchy to renderhead on all appropriate iheadercontributors

the close was called way to early, so that the next component after the first one couldnt contribute to the head anymore because it was already closed

Modified:
    wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java

Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?rev=1040980&r1=1040979&r2=1040980&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java (original)
+++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Wed Dec  1 12:31:47 2010
@@ -681,6 +681,11 @@ public class AjaxRequestTarget implement
 				respondComponent(response, getAjaxRegionMarkupId(component), component);
 			}
 		}
+
+		if (header != null)
+		{
+			header.getHeaderResponse().close();
+		}
 	}
 
 	private String getAjaxRegionMarkupId(Component component)
@@ -1143,7 +1148,6 @@ public class AjaxRequestTarget implement
 				}
 			});
 		}
-		header.getHeaderResponse().close();
 
 		// revert to old response