You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/02/15 09:28:45 UTC

[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1240: [CELEBORN-305] Change the parameter passed in the registerShuffle method to numPartitions instead of numMappers

RexXiong commented on code in PR #1240:
URL: https://github.com/apache/incubator-celeborn/pull/1240#discussion_r1106870978


##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -313,7 +313,7 @@ private ConcurrentHashMap<Integer, PartitionLocation> registerShuffle(
     return registerShuffleInternal(
         shuffleId,
         numMappers,
-        numMappers,

Review Comment:
   Good catch!  Although num partitions is actually correctly used when register shuffle



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org