You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/12 08:58:11 UTC
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1756: chore: update setup script
bisakhmondal opened a new pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Removed the part of the script responsible for downloading the apisix dockerfile.
**Related issues**
Combined with #1744
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-817625611
Deploy preview for *apisix-dashboard* ready!
Built with commit ef7c99f1c055b75cd2ed37731c6e0db57128851d
https://deploy-preview-1756--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-818605230
> @bisakhmondal we should keep this script, we nee to download the Dockerfile when we need to test with APISIX master branch.
Hiii. Okay, sounds good. One thing I'd like to address i.e. the compose file has been changed, so if we want to build the apisix image from the downloaded dockerfile, we have to manually update the compose file (just for the testing and again put it back to the original).
As a hack, I think we can do something like `./setup.sh up --afresh` (--afresh an extra flag) which will
1. Download the dockerfile
2. retag the already present `apache/apisix:2.4-alpine:latest` to `apache/apisix:2.4-alpine:stable`
3. Build an image from the docker file with tag `apache/apisix:2.4-alpine:latest`
A kind of abstraction that doesn't require altering the compose file. When we run `./setup.sh down`, it will revert the steps.
How does it sound to you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-823968082
> > @bisakhmondal we should keep this script, we nee to download the Dockerfile when we need to test with APISIX master branch.
>
> Hiii. Okay, sounds good. One thing I'd like to address i.e. the compose file has been changed, so if we want to build the apisix image from the downloaded dockerfile, we have to manually update the compose file (just for the testing and again put it back to the original).
>
> As a hack, I think we can do something like `./setup.sh up --afresh` (--afresh an extra flag) which will
>
> 1. Download the dockerfile
> 2. retag the already present `apache/apisix:2.4-alpine:latest` to `apache/apisix:2.4-alpine:stable`
> 3. Build an image from the docker file with tag `apache/apisix:2.4-alpine:latest` (just to match the name, under the hood, it may use any version of APISIX)
>
> A kind of abstraction that doesn't require altering the compose file. When we run `./setup.sh down`, it will revert the steps.
>
> How does it sound to you :)
hi @bisakhmondal
Your idea is great.
But I still think it is enough to keep the current state.
The current way is relatively clear.
We don’t need to invest too much time in writing this script and maintaining it.
The benefits are not much, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-823991374
>We don’t need to invest too much time in writing this script and maintaining it.
>The benefits are not much.
+1
Yeah, very true :)
So I think we can close this PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-817625611
Deploy preview for *apisix-dashboard* processing.
Building with commit ef7c99f1c055b75cd2ed37731c6e0db57128851d
https://app.netlify.com/sites/apisix-dashboard/deploys/60740b9e887c300007d8807c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-823800940
Any thoughts here 😄🤡? @nic-chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-818468309
@bisakhmondal we should keep this script, we nee to download the Dockerfile when we need to test with APISIX master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal edited a comment on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
bisakhmondal edited a comment on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-818605230
> @bisakhmondal we should keep this script, we nee to download the Dockerfile when we need to test with APISIX master branch.
Hiii. Okay, sounds good. One thing I'd like to address i.e. the compose file has been changed, so if we want to build the apisix image from the downloaded dockerfile, we have to manually update the compose file (just for the testing and again put it back to the original).
As a hack, I think we can do something like `./setup.sh up --afresh` (--afresh an extra flag) which will
1. Download the dockerfile
2. retag the already present `apache/apisix:2.4-alpine:latest` to `apache/apisix:2.4-alpine:stable`
3. Build an image from the docker file with tag `apache/apisix:2.4-alpine:latest` (just to match the name, under the hood, it may use any version of APISIX)
A kind of abstraction that doesn't require altering the compose file. When we run `./setup.sh down`, it will revert the steps.
How does it sound to you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen edited a comment on pull request #1756: chore: update setup script
Posted by GitBox <gi...@apache.org>.
nic-chen edited a comment on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-823968082
> > @bisakhmondal we should keep this script, we nee to download the Dockerfile when we need to test with APISIX master branch.
>
> Hiii. Okay, sounds good. One thing I'd like to address i.e. the compose file has been changed, so if we want to build the apisix image from the downloaded dockerfile, we have to manually update the compose file (just for the testing and again put it back to the original).
>
> As a hack, I think we can do something like `./setup.sh up --afresh` (--afresh an extra flag) which will
>
> 1. Download the dockerfile
> 2. retag the already present `apache/apisix:2.4-alpine:latest` to `apache/apisix:2.4-alpine:stable`
> 3. Build an image from the docker file with tag `apache/apisix:2.4-alpine:latest` (just to match the name, under the hood, it may use any version of APISIX)
>
> A kind of abstraction that doesn't require altering the compose file. When we run `./setup.sh down`, it will revert the steps.
>
> How does it sound to you :)
hi @bisakhmondal
Your idea is great.
But I still think it is enough to keep the current state.
The current way is relatively clear.
We don’t need to invest too much time in writing this script and maintaining it.
The benefits are not much.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org