[GitHub] [spark] mridulm edited a comment on pull request #34156: [WIP] [SPARK-36892] [Core] Disable batch fetch for a shuffle when push based shuffle is enabled

[GitBox <gi...@apache.org>]

mridulm edited a comment on pull request #34156:
URL: https://github.com/apache/spark/pull/34156#issuecomment-935390374


   The test failure is relevant @zhouyejoe.
   Can you add `conf.set(SERIALIZER, "org.apache.spark.serializer.KryoSerializer")` to all tests which set `conf.set(PUSH_BASED_SHUFFLE_ENABLED, true)` in this Suite ?
   Looks like something which was probably missed out from Minchu's patch.
   
   The root cause here is that we are modifying the global `conf` - which should not have been done in the original PR, and was probably missed in the reviews. We have to fix it in a follow up jira.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org