[GitHub] [camel-k] lburgazzoli commented on a change in pull request #774: fix: Validate maven artifacts

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #774: fix: Validate maven artifacts
URL: https://github.com/apache/camel-k/pull/774#discussion_r297575061
 
 

 ##########
 File path: pkg/cmd/install.go
 ##########
 @@ -434,3 +438,12 @@ func decodeMavenSettings(mavenSettings string) (v1alpha1.ValueSource, error) {
 
 	return v1alpha1.ValueSource{}, fmt.Errorf("illegal maven setting definition, syntax: configmap|secret:resource-name[/settings path]")
 }
+
+func containsMvnCentral(repositories []maven.Repository) bool {
+	for _, r := range repositories {
+		if r.ID == "central" {
 
 Review comment:
   wondering if we should check by ip ? as the id can be set by the user, then it can setanother non maven central repo as central 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services