You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/03 09:47:34 UTC
[GitHub] [iotdb] 23931017wu opened a new pull request, #6886: [IOTDB-4028] Npe in updateNodeLoadStatistic of LoadManager when cluster first starts.
23931017wu opened a new pull request, #6886:
URL: https://github.com/apache/iotdb/pull/6886
### When registering node metrics, the first asynchronous heartbeat has not finished. As a result, the nodeCacheMap is empty, and NPE exception occurs.
### Now, a judgment is added to determine whether the length of nodeCacheMap and the number of registered nodes are equal. If the length is equal, indicators are registered; if not, metrics are prohibited from being registered.
### After the modification, the system restarts without exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] 23931017wu commented on a diff in pull request #6886: [IOTDB-4028] Npe in updateNodeLoadStatistic of LoadManager when cluster first starts.
Posted by GitBox <gi...@apache.org>.
23931017wu commented on code in PR #6886:
URL: https://github.com/apache/iotdb/pull/6886#discussion_r937281988
##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/NodeInfo.java:
##########
@@ -268,6 +268,21 @@ public int getRegisteredConfigNodeCount() {
}
return result;
}
+
+ /** Return the number of registered ConfigNodes */
+ public int getRegisteredNodeCount() {
+ int result;
Review Comment:
Okay, I get it ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on a diff in pull request #6886: [IOTDB-4028] Npe in updateNodeLoadStatistic of LoadManager when cluster first starts.
Posted by GitBox <gi...@apache.org>.
neuyilan commented on code in PR #6886:
URL: https://github.com/apache/iotdb/pull/6886#discussion_r937280381
##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/NodeInfo.java:
##########
@@ -268,6 +268,21 @@ public int getRegisteredConfigNodeCount() {
}
return result;
}
+
+ /** Return the number of registered ConfigNodes */
+ public int getRegisteredNodeCount() {
+ int result;
Review Comment:
Change the comment, please. actually, this method calculated the total number of nodes for confignodes and datanodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan merged pull request #6886: [IOTDB-4028] Npe in updateNodeLoadStatistic of LoadManager when cluster first starts.
Posted by GitBox <gi...@apache.org>.
neuyilan merged PR #6886:
URL: https://github.com/apache/iotdb/pull/6886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org