[GitHub] [beam] kennknowles commented on a diff in pull request #22183: Moves timestamp skew override to correct place

[GitBox <gi...@apache.org>]

kennknowles commented on code in PR #22183:
URL: https://github.com/apache/beam/pull/22183#discussion_r917095292


##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -2366,6 +2361,11 @@ protected BulkIOBaseFn(BulkIO bulkSpec) {
         this.spec = bulkSpec;
       }
 
+      @Override
+      public Duration getAllowedTimestampSkew() {
+        return Duration.millis(Long.MAX_VALUE);

Review Comment:
   This won't affect the watermark, so it will just allow output to be dropped if it is assigned to an expired window.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org