You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Heesung Sohn <he...@streamnative.io.INVALID> on 2022/04/18 18:25:13 UTC

PIP-156: Build and Run Pulsar Server on Java 17

Dear Pulsar dev community,

My name is Heesung Sohn, and I would like to open a discussion here
about PIP-156:
Build and Run Pulsar Server on Java 17
<https://github.com/apache/pulsar/issues/15207>.


@Nicolò Boschi,
I see your similar PR <https://github.com/apache/pulsar/pull/14355> for the
Java 17 runtime support. Since some of the Java 17 upgrade work could
overlap, it would be great if we can discuss how to collaborate too -- for
this PIP, we need to additionally update the `javac --release` option to
Java 17.

Regards,
Heesung
-- 

<https://streamnative.io>

Heesung Sohn

Platform Engineer

e: heesung.sohn@streamnative.io

streamnative.io

<http://github.com/streamnative>
<https://www.linkedin.com/company/streamnative/>
<https://twitter.com/streamnativeio/>

Re: PIP-156: Build and Run Pulsar Server on Java 17

Posted by Heesung Sohn <he...@streamnative.io.INVALID>.
Hi Lari,

Thank you for providing the context about the ongoing work.

I added my comments on the email thread
<https://lists.apache.org/thread/c0k8p9vy5wyp9l70mt980gdy10smx6qb>
<https://lists.apache.org/thread/c0k8p9vy5wyp9l70mt980gdy10smx6qb>and the PR
<https://github.com/apache/pulsar/pull/14355>.

Regards,
Heesung







On Wed, Apr 20, 2022 at 9:53 AM Lari Hotari <lh...@apache.org> wrote:

> Hi Heesung,
>
> I support this proposal, but I would have expected you to first reply on
> the email thread started by Nicolo in February
> https://lists.apache.org/thread/c0k8p9vy5wyp9l70mt980gdy10smx6qb .
>
> Nicolo Boschi has been working on Java 17 compatibility for months and
> also brought this up to discussion on the mailing list and in the Pulsar
> community meetings several times in the past.
> Last discussion about the Java 17 work was recorded in these community
> meeting notes:
> https://lists.apache.org/thread/tq7dsws72zf9r7qzr4l567z9w346ksbm .
>
> The credits for Java 17 compatibility goes to Nicolo. I expect that
> members of the Pulsar community pay more attention to ongoing work that is
> announced on the dev mailing list.
>
> In this case, it would have been fair to provide feedback on the "JDK 17
> runtime compatibility" thread that Nicolo started in February or comment on
> the PR https://github.com/apache/pulsar/pull/14355 which takes the move
> to use Java 17 for CI and for the Docker images.
>
> -Lari
>
> On 2022/04/18 18:25:13 Heesung Sohn wrote:
> > Dear Pulsar dev community,
> >
> > My name is Heesung Sohn, and I would like to open a discussion here
> > about PIP-156:
> > Build and Run Pulsar Server on Java 17
> > <https://github.com/apache/pulsar/issues/15207>.
> >
> >
> > @Nicolò Boschi,
> > I see your similar PR <https://github.com/apache/pulsar/pull/14355> for
> the
> > Java 17 runtime support. Since some of the Java 17 upgrade work could
> > overlap, it would be great if we can discuss how to collaborate too --
> for
> > this PIP, we need to additionally update the `javac --release` option to
> > Java 17.
> >
> > Regards,
> > Heesung
> > --
> >
> > <https://streamnative.io>
> >
> > Heesung Sohn
> >
> > Platform Engineer
> >
> > e: heesung.sohn@streamnative.io
> >
> > streamnative.io
> >
> > <http://github.com/streamnative>
> > <https://www.linkedin.com/company/streamnative/>
> > <https://twitter.com/streamnativeio/>
> >
>

Re: PIP-156: Build and Run Pulsar Server on Java 17

Posted by Lari Hotari <lh...@apache.org>.
Hi Heesung,

I support this proposal, but I would have expected you to first reply on the email thread started by Nicolo in February https://lists.apache.org/thread/c0k8p9vy5wyp9l70mt980gdy10smx6qb .

Nicolo Boschi has been working on Java 17 compatibility for months and also brought this up to discussion on the mailing list and in the Pulsar community meetings several times in the past. 
Last discussion about the Java 17 work was recorded in these community meeting notes: https://lists.apache.org/thread/tq7dsws72zf9r7qzr4l567z9w346ksbm .

The credits for Java 17 compatibility goes to Nicolo. I expect that members of the Pulsar community pay more attention to ongoing work that is announced on the dev mailing list. 

In this case, it would have been fair to provide feedback on the "JDK 17 runtime compatibility" thread that Nicolo started in February or comment on the PR https://github.com/apache/pulsar/pull/14355 which takes the move to use Java 17 for CI and for the Docker images.

-Lari

On 2022/04/18 18:25:13 Heesung Sohn wrote:
> Dear Pulsar dev community,
> 
> My name is Heesung Sohn, and I would like to open a discussion here
> about PIP-156:
> Build and Run Pulsar Server on Java 17
> <https://github.com/apache/pulsar/issues/15207>.
> 
> 
> @Nicolò Boschi,
> I see your similar PR <https://github.com/apache/pulsar/pull/14355> for the
> Java 17 runtime support. Since some of the Java 17 upgrade work could
> overlap, it would be great if we can discuss how to collaborate too -- for
> this PIP, we need to additionally update the `javac --release` option to
> Java 17.
> 
> Regards,
> Heesung
> -- 
> 
> <https://streamnative.io>
> 
> Heesung Sohn
> 
> Platform Engineer
> 
> e: heesung.sohn@streamnative.io
> 
> streamnative.io
> 
> <http://github.com/streamnative>
> <https://www.linkedin.com/company/streamnative/>
> <https://twitter.com/streamnativeio/>
> 

Re: PIP-156: Build and Run Pulsar Server on Java 17

Posted by Nicolò Boschi <bo...@gmail.com>.
Heesung, thanks for the heads up.

I added a comment in the PIP. I believe that the compile compatibility can
be addressed with another pull and it does not overlap mine.

Nicolò Boschi


Il giorno lun 18 apr 2022 alle ore 20:25 Heesung Sohn <
heesung.sohn@streamnative.io> ha scritto:

> Dear Pulsar dev community,
>
> My name is Heesung Sohn, and I would like to open a discussion here about PIP-156:
> Build and Run Pulsar Server on Java 17
> <https://github.com/apache/pulsar/issues/15207>.
>
>
> @Nicolò Boschi,
> I see your similar PR <https://github.com/apache/pulsar/pull/14355> for
> the Java 17 runtime support. Since some of the Java 17 upgrade work could
> overlap, it would be great if we can discuss how to collaborate too -- for
> this PIP, we need to additionally update the `javac --release` option to
> Java 17.
>
> Regards,
> Heesung
> --
>
> <https://streamnative.io>
>
> Heesung Sohn
>
> Platform Engineer
>
> e: heesung.sohn@streamnative.io
>
> streamnative.io
>
> <http://github.com/streamnative>
> <https://www.linkedin.com/company/streamnative/>
> <https://twitter.com/streamnativeio/>
>

Re: PIP-156: Build and Run Pulsar Server on Java 17

Posted by PengHui Li <pe...@apache.org>.
Hi Heesung,

Great work! I support the change.

Thanks,
Penghui

On Thu, May 19, 2022 at 7:46 AM Heesung Sohn
<he...@streamnative.io.invalid> wrote:

> Hi,
>
> As a follow-up task here, I have a proposal to update pulsar server default
> GC configs. I tried to summarize the details in my fork PR:
> https://github.com/heesung-sn/pulsar/pull/1, and It would be great if I
> could get some early feedback from the community.
>
> Thank you,
> Heesung
>
> On Thu, Apr 21, 2022 at 4:00 AM Jiuming Tao <jmtao@streamnative.io.invalid
> >
> wrote:
>
> > +1
> > Thanks,
> > Tao Jiuming
> >
> > > 2022年4月19日 上午2:25,Heesung Sohn <he...@streamnative.io.INVALID>
> > 写道:
> > >
> > > Dear Pulsar dev community,
> > >
> > > My name is Heesung Sohn, and I would like to open a discussion here
> > > about PIP-156:
> > > Build and Run Pulsar Server on Java 17
> > > <https://github.com/apache/pulsar/issues/15207>.
> > >
> > >
> > > @Nicolò Boschi,
> > > I see your similar PR <https://github.com/apache/pulsar/pull/14355>
> for
> > the
> > > Java 17 runtime support. Since some of the Java 17 upgrade work could
> > > overlap, it would be great if we can discuss how to collaborate too --
> > for
> > > this PIP, we need to additionally update the `javac --release` option
> to
> > > Java 17.
> > >
> > > Regards,
> > > Heesung
> > > --
> > >
> > > <https://streamnative.io>
> > >
> > > Heesung Sohn
> > >
> > > Platform Engineer
> > >
> > > e: heesung.sohn@streamnative.io
> > >
> > > streamnative.io
> > >
> > > <http://github.com/streamnative>
> > > <https://www.linkedin.com/company/streamnative/>
> > > <https://twitter.com/streamnativeio/>
> >
> >
>

Re: PIP-156: Build and Run Pulsar Server on Java 17

Posted by Heesung Sohn <he...@streamnative.io.INVALID>.
Hi,

As a follow-up task here, I have a proposal to update pulsar server default
GC configs. I tried to summarize the details in my fork PR:
https://github.com/heesung-sn/pulsar/pull/1, and It would be great if I
could get some early feedback from the community.

Thank you,
Heesung

On Thu, Apr 21, 2022 at 4:00 AM Jiuming Tao <jm...@streamnative.io.invalid>
wrote:

> +1
> Thanks,
> Tao Jiuming
>
> > 2022年4月19日 上午2:25,Heesung Sohn <he...@streamnative.io.INVALID>
> 写道:
> >
> > Dear Pulsar dev community,
> >
> > My name is Heesung Sohn, and I would like to open a discussion here
> > about PIP-156:
> > Build and Run Pulsar Server on Java 17
> > <https://github.com/apache/pulsar/issues/15207>.
> >
> >
> > @Nicolò Boschi,
> > I see your similar PR <https://github.com/apache/pulsar/pull/14355> for
> the
> > Java 17 runtime support. Since some of the Java 17 upgrade work could
> > overlap, it would be great if we can discuss how to collaborate too --
> for
> > this PIP, we need to additionally update the `javac --release` option to
> > Java 17.
> >
> > Regards,
> > Heesung
> > --
> >
> > <https://streamnative.io>
> >
> > Heesung Sohn
> >
> > Platform Engineer
> >
> > e: heesung.sohn@streamnative.io
> >
> > streamnative.io
> >
> > <http://github.com/streamnative>
> > <https://www.linkedin.com/company/streamnative/>
> > <https://twitter.com/streamnativeio/>
>
>

Re: PIP-156: Build and Run Pulsar Server on Java 17

Posted by Jiuming Tao <jm...@streamnative.io.INVALID>.
+1
Thanks,
Tao Jiuming

> 2022年4月19日 上午2:25,Heesung Sohn <he...@streamnative.io.INVALID> 写道:
> 
> Dear Pulsar dev community,
> 
> My name is Heesung Sohn, and I would like to open a discussion here
> about PIP-156:
> Build and Run Pulsar Server on Java 17
> <https://github.com/apache/pulsar/issues/15207>.
> 
> 
> @Nicolò Boschi,
> I see your similar PR <https://github.com/apache/pulsar/pull/14355> for the
> Java 17 runtime support. Since some of the Java 17 upgrade work could
> overlap, it would be great if we can discuss how to collaborate too -- for
> this PIP, we need to additionally update the `javac --release` option to
> Java 17.
> 
> Regards,
> Heesung
> -- 
> 
> <https://streamnative.io>
> 
> Heesung Sohn
> 
> Platform Engineer
> 
> e: heesung.sohn@streamnative.io
> 
> streamnative.io
> 
> <http://github.com/streamnative>
> <https://www.linkedin.com/company/streamnative/>
> <https://twitter.com/streamnativeio/>