You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/15 05:46:25 UTC

[GitHub] [flink] Aitozi commented on a diff in pull request #20256: [FLINK-24713][Runtime/Coordination] Postpone resourceManager serving

Aitozi commented on code in PR #20256:
URL: https://github.com/apache/flink/pull/20256#discussion_r921831385


##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManager.java:
##########
@@ -244,6 +254,20 @@ public void onPreviousAttemptWorkersRecovered(Collection<WorkerType> recoveredWo
                     "Worker {} recovered from previous attempt.",
                     resourceId.getStringWithMetadata());
         }
+        if (recoveredWorkers.size() > 0) {
+            scheduleRunAsync(
+                    () -> {
+                        if (!recoveryFuture.isDone()) {

Review Comment:
   If when timeout reached, and the future is completed by register success, there is no need to log the timeout 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org