You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/17 21:43:12 UTC

[GitHub] [pinot] mapshen opened a new issue #7924: `pinot.server.instance.reload.consumingSegment` deprecated?

mapshen opened a new issue #7924:
URL: https://github.com/apache/pinot/issues/7924


   There are several references to `pinot.server.instance.reload.consumingSegment` in the docs such as [1] and [2]. When I go to the code base at [3], it seems `CONFIG_OF_INSTANCE_RELOAD_CONSUMING_SEGMENT ` is never used anywhere.
   
   ```
       public static final String CONFIG_OF_INSTANCE_RELOAD_CONSUMING_SEGMENT =
           "pinot.server.instance.reload.consumingSegment";
   ```
   
   
   
   [1] https://docs.pinot.apache.org/configuration-reference/server
   [2] https://docs.pinot.apache.org/users/tutorials/schema-evolution
   [3] https://github.com/apache/pinot/blob/12edbdb1e521e0d9ee35a2d6ef2fed172e5beaa1/pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java#L254-L255


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] mapshen commented on issue #7924: `pinot.server.instance.reload.consumingSegment` deprecated?

Posted by GitBox <gi...@apache.org>.
mapshen commented on issue #7924:
URL: https://github.com/apache/pinot/issues/7924#issuecomment-997075188


   > It is used in `HelixInstanceDataManagerConfig.shouldReloadConsumingSegment()`. There is no directly access to the constant because the prefix is trimmed off in the instance data manager config.
   
   As per [1], `pinot.server.instance.reload.consumingSegment` is set to `false` by default, but based on our tests, without setting this to `true`, the current consuming segment(s) will still reflect the default null value for newly added columns, which conflicts with what documented at [2]
   
   
   > Real-Time Pinot table: In case of real-time tables, make sure the "pinot.server.instance.reload.consumingSegment" config is set to true inside Server config. Without this, the current consuming segment(s) will not reflect the default null value for newly added columns.
   
   [1] https://docs.pinot.apache.org/configuration-reference/server
   [2] https://docs.pinot.apache.org/users/tutorials/schema-evolution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #7924: `pinot.server.instance.reload.consumingSegment` deprecated?

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7924:
URL: https://github.com/apache/pinot/issues/7924#issuecomment-997076427


   Good catch! I think we forgot to update the documentation. The default is actually true (CommonConstants.Server.DEFAULT_RELOAD_CONSUMING_SEGMENT). Let me update the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #7924: `pinot.server.instance.reload.consumingSegment` deprecated?

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7924:
URL: https://github.com/apache/pinot/issues/7924#issuecomment-997073189


   It is used in `HelixInstanceDataManagerConfig.shouldReloadConsumingSegment()`. There is no directly access to the constant because the prefix is trimmed off in the instance data manager config.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org