You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/06 02:09:51 UTC

Review Request 15254: Fixed the flaky ReconcileTasksMissingFromSlave test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15254/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-801
    https://issues.apache.org/jira/browse/MESOS-801


Repository: mesos-git


Description
-------

See linked bug.


Diffs
-----

  src/tests/slave_recovery_tests.cpp 37faf2054750080902cb06b62da9a9e2252c566f 

Diff: https://reviews.apache.org/r/15254/diff/


Testing
-------

Ran this with 1400 runs.


Thanks,

Ben Mahler


Re: Review Request 15254: Fixed the flaky ReconcileTasksMissingFromSlave test.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15254/#review28244
-----------------------------------------------------------

Ship it!



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/15254/#comment54960>

    Do will repeatedly instead.



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/15254/#comment54961>

    kill this.


- Vinod Kone


On Nov. 6, 2013, 1:09 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15254/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 1:09 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-801
>     https://issues.apache.org/jira/browse/MESOS-801
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See linked bug.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 37faf2054750080902cb06b62da9a9e2252c566f 
> 
> Diff: https://reviews.apache.org/r/15254/diff/
> 
> 
> Testing
> -------
> 
> Ran this with 1400 runs.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 15254: Fixed the flaky ReconcileTasksMissingFromSlave test.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15254/
-----------------------------------------------------------

(Updated Nov. 6, 2013, 1:39 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Vinod's comments, NNFR.


Bugs: MESOS-801
    https://issues.apache.org/jira/browse/MESOS-801


Repository: mesos-git


Description
-------

See linked bug.


Diffs (updated)
-----

  src/tests/slave_recovery_tests.cpp 37faf2054750080902cb06b62da9a9e2252c566f 

Diff: https://reviews.apache.org/r/15254/diff/


Testing
-------

Ran this with 1400 runs.


Thanks,

Ben Mahler