You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2025/11/06 16:49:36 UTC
[I] feat: CometWindowExec should correctly account output attributes [datafusion-comet]
comphead opened a new issue, #2710:
URL: https://github.com/apache/datafusion-comet/issues/2710
### What is the problem the feature request solves?
Current plan for windows is
```
val df = sql("SELECT a, b, c, SUM(c) OVER (PARTITION BY a) as sum_c FROM window_test")
+- !CometWindowExec [a#19, b#20, c#21, sum_c#25L], [sum(c#21) windowspecdefinition(a#19, specifiedwindowframe(RowFrame, unboundedpreceding$(), unboundedfollowing$())) AS sum_c#25L], [a#19]
+- CometSort [a#19, b#20, c#21], [a#19 ASC NULLS FIRST]
+- CometExchange hashpartitioning(a#19, 10), ENSURE_REQUIREMENTS, CometNativeShuffle, [plan_id=87]
+- CometScan [native_iceberg_compat] parquet [a#19,b#20,c#21] Batched: true, DataFilters: [], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/private/var/folders/6f/_s1vnnd55zgfkx7zlwnrnv0h0000gn/T/spark-89..., PartitionFilters: [], PushedFilters: [], ReadSchema: struct<a:int,b:int,c:int>
```
The exclamation mark usually means discrepancy for `outputAttributes`. Refer to https://github.com/apache/datafusion-comet/issues/2214
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] feat: CometWindowExec should correctly account output attributes [datafusion-comet]
Posted by "rahulbabarwal89 (via GitHub)" <gi...@apache.org>.
rahulbabarwal89 commented on issue #2710:
URL: https://github.com/apache/datafusion-comet/issues/2710#issuecomment-3535777259
@comphead , i can get started with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] feat: CometWindowExec should correctly account output attributes [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead closed issue #2710: feat: CometWindowExec should correctly account output attributes
URL: https://github.com/apache/datafusion-comet/issues/2710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] feat: CometWindowExec should correctly account output attributes [datafusion-comet]
Posted by "rahulbabarwal89 (via GitHub)" <gi...@apache.org>.
rahulbabarwal89 commented on issue #2710:
URL: https://github.com/apache/datafusion-comet/issues/2710#issuecomment-3536616158
Raised this PR for the same : https://github.com/apache/datafusion-comet/pull/2789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] feat: CometWindowExec should correctly account output attributes [datafusion-comet]
Posted by "rahulbabarwal89 (via GitHub)" <gi...@apache.org>.
rahulbabarwal89 commented on issue #2710:
URL: https://github.com/apache/datafusion-comet/issues/2710#issuecomment-3538932864
All the tests are passing here. @comphead , please let me know in case any other test needs to be added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org