You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/09/01 01:35:20 UTC

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Hello Dan Burkert, Grant Henke, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7927

to look at the new patch set (#5).

Change subject: gradle: convert gradle-wrapper.properties into a real generated file
......................................................................

gradle: convert gradle-wrapper.properties into a real generated file

Let's handle gradle-wrapper.properties the same way as gradle-wrapper.jar:
by downloading it during invocations of gradlew if it's not already there.

I also put gradle/wrapper into .gitignore since it is only expected to
contain generated files.

Finally, I added an ASL2 header to gradlew and linked to it from Kudu's
central license file.

Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
---
M LICENSE.txt
M java/.gitignore
M java/gradle/wrapper.gradle
D java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
5 files changed, 31 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/7927/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02f31865b27f186291d18f7683c5e40698b8ce37
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>