[GitHub] dongjoon-hyun commented on a change in pull request #23912: [SPARK-21029][SS] StreamingQuery should be stopped when the SparkSession is stopped

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23912: [SPARK-21029][SS] StreamingQuery should be stopped when the SparkSession is stopped
URL: https://github.com/apache/spark/pull/23912#discussion_r261429462
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
 ##########
 @@ -723,6 +725,11 @@ class SparkSession private(
    * @since 2.0.0
    */
   def stop(): Unit = {
+    if (!stopped.compareAndSet(false, true)) {
+      logInfo("SparkSession already stopped.")
+      return
 
 Review comment:
   Hi, @arunmahadevan . Could you revise this to avoid `return` statement?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org