You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/08/05 05:09:21 UTC

Review Request 24292: Forced mesos_pb2 to be generated in a flat fashion.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24292/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description
-------

This fixes the regression caused by https://reviews.apache.org/r/23704/


Diffs
-----

  src/Makefile.am 04be4e0892c9d592b0880edddcd4c28896cc8dd1 

Diff: https://reviews.apache.org/r/24292/diff/


Testing
-------

make python/interface/src/mesos/interface/mesos_pb2.py


Thanks,

Thomas Rampelberg


Re: Review Request 24292: Forced mesos_pb2 to be generated in a flat fashion.

Posted by Niklas Nielsen <ni...@qni.dk>.

> On Aug. 4, 2014, 10:52 p.m., Niklas Nielsen wrote:
> > Ship It!

Thanks Thomas - just committed your patch!


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24292/#review49566
-----------------------------------------------------------


On Aug. 4, 2014, 8:09 p.m., Thomas Rampelberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24292/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 8:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This fixes the regression caused by https://reviews.apache.org/r/23704/
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 04be4e0892c9d592b0880edddcd4c28896cc8dd1 
> 
> Diff: https://reviews.apache.org/r/24292/diff/
> 
> 
> Testing
> -------
> 
> make python/interface/src/mesos/interface/mesos_pb2.py
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>


Re: Review Request 24292: Forced mesos_pb2 to be generated in a flat fashion.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24292/#review49566
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Aug. 4, 2014, 8:09 p.m., Thomas Rampelberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24292/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 8:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This fixes the regression caused by https://reviews.apache.org/r/23704/
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 04be4e0892c9d592b0880edddcd4c28896cc8dd1 
> 
> Diff: https://reviews.apache.org/r/24292/diff/
> 
> 
> Testing
> -------
> 
> make python/interface/src/mesos/interface/mesos_pb2.py
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>