[no virus] RE: New Redirect & sons becoming available

[Vincenzo Gianferrari Pini <vi...@praxis.it>]

Noel,

I'm attaching the final (?) version of the new Redirect and other related mailets. I have tested everything doing my best, but I suggest you and others to test it again.

The classes are:

AbstractRedirect
Forward extends AbstractRedirect
Redirect extends AbstractRedirect
AbstractNotify extends AbstractRedirect
Bounce extends AbstractNotify 
NotifySender extends AbstractNotify
NotifyPostmaster extends AbstractNotify

The backwards compatibility should be complete for existing subclasses of Redirect and the various config.xml using NotifySender and NotifyPostmaster.

Bounce, NotifySender and NotifyPostmaster share the same inline message text; NotifyPostmaster had a slightly richer one than NotifySender, and has become the common one for all three.

I'm wondering if the fake sender domain check done in Forward should be shared by all the mailets. What do you think?

I've added all the javadocs (hopefully I haven't missed any - please check).

Finally, as a curiosity for you, the AddressMarker and the SpecialAddress code you sent me had a small error, that was difficult to find: the various

                MailAddress SENDER      = new MailAddress("sender","Address.Marker");
                ...

must be

                SENDER      = new MailAddress("sender","Address.Marker");
                ...

The effect was that all special address constants were null.

------------------------

Please let me know your feedback.

Vincenzo

RE: [no virus] RE: New Redirect & sons becoming available

["Noel J. Bergman" <no...@devtech.com>]

>   http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18028
> I believe that the new code still has that problem.  I've a tentative
> solution in mind that I'll post after committing your submission.

Not quite.  The new code rendered it as:

Message:
javax.mail.internet.MimeMultipart@88df60

Next up to try a fix.

	--- Noel

---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org

RE: [no virus] RE: New Redirect & sons becoming available

["Noel J. Bergman" <no...@devtech.com>]

Vincenzo,

I'll get it committed.  In the meantime, would you please look at:

  http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18028

I believe that the new code still has that problem.  I've a tentative
solution in mind that I'll post after committing your submission.

  http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18309

> NotifyPostmaster had a slightly richer [notification message, which]
> has become the common one for all three.

The request in 18309 might apply to AbstractNotify.

> I'm wondering if the fake sender domain check done in Forward
> should be shared by all the mailets.

Possibly, but it should only be done if we are going to USE the Sender
domain.  If we are just forwarding the message from Postmaster, for example,
we don't USE the original Sender, and can preserve it.  This is useful if
you have a mailet like:

         <mailet match="All" class="Redirect">
            <recipients>uce@ftc.gov</recipients>
            <sender>postmaster</sender>
            <returnpath>null</returnpath>
            <inline>unaltered</inline>
            <passThrough>true</passThrough>
            <static>true</static>
         </mailet>

All in all, Vincenzo, I think you've done a great job!  :-)

	--- Noel


---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org

RE: [no virus] RE: New Redirect & sons becoming available

["Noel J. Bergman" <no...@devtech.com>]

Vincenzo,

In AbstractRedirect.buildAlteredMessage(Mail, Mail), shouldn't the two uses
of getAttachmentType() be getAttachmentType(originalMail)?

	--- Noel


---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org