[GitHub] [hadoop] xinglin commented on a diff in pull request #5067: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

[GitBox <gi...@apache.org>]

xinglin commented on code in PR #5067:
URL: https://github.com/apache/hadoop/pull/5067#discussion_r1008330919


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java:
##########
@@ -417,24 +408,18 @@ private void processTokenAddOrUpdate(byte[] data) throws IOException {
     if (numRead > -1) {
       DelegationTokenInformation tokenInfo =
           new DelegationTokenInformation(renewDate, password);
-      synchronized (this) {

Review Comment:
   This change removes a few synchronized keywords. I cross-check with trunk and trunk also removes these. seems fine but I have no context on why synchronized was used before and now removed.



##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java:
##########
@@ -101,6 +101,7 @@ public void testMultiNodeOperationWithoutWatch() throws Exception {
     }
   }
 
+  @SuppressWarnings("unchecked")

Review Comment:
   trunk does not suppress here. Maybe we shouldn't neither?



##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java:
##########
@@ -162,6 +162,7 @@ public void testMultiNodeTokenRemovalShortSyncWithoutWatch()
 
   // This is very unlikely to happen in real case, but worth putting
   // the case out
+  @SuppressWarnings("unchecked")

Review Comment:
   trunk does not have suppress here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org