[GitHub] [cloudstack] rhtyd commented on a change in pull request #5320: db: use id column as secondary sort criteria

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #5320:
URL: https://github.com/apache/cloudstack/pull/5320#discussion_r690266764



##########
File path: framework/db/src/main/java/com/cloud/utils/db/Filter.java
##########
@@ -77,7 +77,9 @@ public void addOrderBy(Class<?> clazz, String field, boolean ascending) {
 
         Column column = f.getAnnotation(Column.class);
         String name = column != null ? column.name() : field;
-
+        if (!name.equals("id")) {
+            name = String.format("%s, id", name);

Review comment:
       LGTM but I worry as this is used at so many places, @shwstppr - is there a more isolated way to fix the list API issue than this, i.e. what is causing the issue for the listServiceOfferings API response?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org