You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Vadim Gritsenko <va...@reverycodes.com> on 2004/11/10 04:12:30 UTC

Re: svn commit: rev 57089 - cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron

giacomo@apache.org wrote:
> Author: giacomo
> Date: Tue Nov  9 11:53:45 2004
> New Revision: 57089
> 
> Modified:
>    cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java
> Log:
> try to fix reload problem
> 
> Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java
> ==============================================================================
> --- cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java	(original)
> +++ cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java	Tue Nov  9 11:53:45 2004
> @@ -316,10 +316,10 @@
>              // we cannot create the same scheduler again
>              final String runID = new Date().toString().replace(' ', '_');
>              final QuartzThreadPool pool = createThreadPool(this.config.getChild("thread-pool"));
> -            final JobStore store = createJobStore(DEFAULT_QUARTZ_SCHEDULER_NAME, runID, this.config.getChild("store"));
> -            DirectSchedulerFactory.getInstance().createScheduler(DEFAULT_QUARTZ_SCHEDULER_NAME, runID, pool, store);
> +            final JobStore store = createJobStore(DEFAULT_QUARTZ_SCHEDULER_NAME + runID, runID, this.config.getChild("store"));
> +            DirectSchedulerFactory.getInstance().createScheduler(DEFAULT_QUARTZ_SCHEDULER_NAME + runID, runID, pool, store);

IMHO, it should cause problem with JDBC job store, and with clustered Cocoon 
servers also. Point of JDBC store is to coordinate cron jobs between several 
Cocoon instances.

Vadim

Re: svn commit: rev 57089 - cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron

Posted by Giacomo Pati <gi...@apache.org>.
On Tue, 9 Nov 2004, Vadim Gritsenko wrote:

> giacomo@apache.org wrote:
>> Author: giacomo
>> Date: Tue Nov  9 11:53:45 2004
>> New Revision: 57089
>> 
>> Modified:
>>   cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java
>> Log:
>> try to fix reload problem
>> 
>> Modified: 
>> cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java
>> ==============================================================================
>> --- 
>> cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java 
>> (original)
>> +++ 
>> cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron/QuartzJobScheduler.java 
>> Tue Nov  9 11:53:45 2004
>> @@ -316,10 +316,10 @@
>> // we cannot create the same scheduler again
>> final String runID = new Date().toString().replace(' ', 
>> '_');
>> final QuartzThreadPool pool = 
>> createThreadPool(this.config.getChild("thread-pool"));
>> -            final JobStore store = 
>> createJobStore(DEFAULT_QUARTZ_SCHEDULER_NAME, runID, 
>> this.config.getChild("store"));
>> - 
>> DirectSchedulerFactory.getInstance().createScheduler(DEFAULT_QUARTZ_SCHEDULER_NAME, 
>> runID, pool, store);
>> +            final JobStore store = 
>> createJobStore(DEFAULT_QUARTZ_SCHEDULER_NAME + runID, runID, 
>> this.config.getChild("store"));
>> + 
>> DirectSchedulerFactory.getInstance().createScheduler(DEFAULT_QUARTZ_SCHEDULER_NAME 
>> + runID, runID, pool, store);
>
> IMHO, it should cause problem with JDBC job store, and with clustered Cocoon 
> servers also. Point of JDBC store is to coordinate cron jobs between several 
> Cocoon instances.

Uh, sorry. I'll reverse it. The problem I've tried to fix is the 
occassionally reloading of cocoon from the container will kill the cron 
scheduler.

-- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com

Re: svn commit: rev 57089 - cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron

Posted by Giacomo Pati <gi...@apache.org>.
On Tue, 9 Nov 2004, Vadim Gritsenko wrote:

> Vadim Gritsenko wrote:
>> giacomo@apache.org wrote:
>> 
>>> DirectSchedulerFactory.getInstance().createScheduler(DEFAULT_QUARTZ_SCHEDULER_NAME 
>>> + runID, runID, pool, store);
>> 
>> 
>> IMHO, it should cause problem with JDBC job store, and with clustered 
>> Cocoon servers also. Point of JDBC store is to coordinate cron jobs 
>> between several Cocoon instances.
>
> ... or may be not. Have you used quartz + jdbc store configuration?

No, I don't actually (do not have any experience with jdbc store at all)

-- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com

Re: svn commit: rev 57089 - cocoon/branches/BRANCH_2_1_X/src/blocks/cron/java/org/apache/cocoon/components/cron

Posted by Vadim Gritsenko <va...@reverycodes.com>.
Vadim Gritsenko wrote:
> giacomo@apache.org wrote:
> 
>> DirectSchedulerFactory.getInstance().createScheduler(DEFAULT_QUARTZ_SCHEDULER_NAME 
>> + runID, runID, pool, store);
> 
> 
> IMHO, it should cause problem with JDBC job store, and with clustered 
> Cocoon servers also. Point of JDBC store is to coordinate cron jobs 
> between several Cocoon instances.

... or may be not. Have you used quartz + jdbc store configuration?

Vadim