You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/03/29 01:10:18 UTC

[GitHub] [incubator-yunikorn-web] wilfred-s commented on pull request #54: [YUNIKORN-569] Display pod namespace/name for the allocations on the apps/nodes page

wilfred-s commented on pull request #54:
URL: https://github.com/apache/incubator-yunikorn-web/pull/54#issuecomment-809001959


   I think we need to look at the basic display of the data. Yes we need to make thing human readable but we also need to prevent displaying the same information over and over.
   * An allocation displayed as part of a node does not need to show the nodeID or the partition. They cannot change for a node and I know which node I am looking at. That information is already there in the overview of the node.
   * When looking at an app I see a similar issue. I do not need to see the appID, partition or the queue for the allocation information when I look at an app. That is always the same and should just be shown in the app overview.
   
   Re-ordering of the data that is displayed, i.e. appID should be close the the key when looking at the node allocations. etc will also improve readability a lot.
   Last point to make is that removing the key for allocations from the web UI will break any possibility to track that allocation in the logs. The key (ID) will be logged in the files so if you need to troubleshoot anything you need that and we cannot just remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org