[jira] [Comment Edited] (KAFKA-12773) Use UncheckedIOException when wrapping IOException

["Jose Armando Garcia Sancio (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349823#comment-17349823 ] 

Jose Armando Garcia Sancio edited comment on KAFKA-12773 at 5/22/21, 7:49 PM:
------------------------------------------------------------------------------

The {{raft}} module may not be fully consistent on this but in general in that module we have decided to not throw the checked {{IOException}}. Up to now we have been doing this by wrapping {{IOException}} with {{RuntimeException}}. [~mumrah] suggested in a PR to use {{UncheckedIOException}}. This Jira was created to track that suggestion.

If you are going to work on this, you can scan all of the code in the {{raft}} module (top level directory) and change any instance where we wrap {{IOException}} into another exception to instead use {{UncheckedIOException}}.


was (Author: jagsancio):
The {{raft}} modlue may not be fully consistent on this but in general in that module we have decided to not throw the checked {{IOException}}. Up to now we have been doing this by wrapping {{IOException}} with {{RuntimeException}}. [~mumrah] suggested in a PR to use{{UncheckedIOException}}. This Jira was created to track that suggestion.

If you are going to work on this, you can scan all of the code in the {{raft}} module (top level directory) and change any instance where we wrap {{IOException}} into another exception to instead use {{UncheckedIOException}}.

> Use UncheckedIOException when wrapping IOException
> --------------------------------------------------
>
>                 Key: KAFKA-12773
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12773
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Jose Armando Garcia Sancio
>            Assignee: loboxu
>            Priority: Major
>              Labels: kip-500, newbie
>
> The {{raft}} module may not be fully consistent on this but in general in that module we have decided to not throw the checked {{IOException}}. We have been avoiding checked {{IOException}} exceptions by wrapping them in {{RuntimeException}}. The {{raft}} module should instead wrap {{IOException}} in {{UncheckedIOException}}. This change should be limited to the {{raft}} module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)