You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/09/13 20:22:20 UTC
[GitHub] [activemq-artemis] tabish121 opened a new pull request, #4214: ARTEMIS-3990 Ensure that readable buffer string read consumes the bytes
tabish121 opened a new pull request, #4214:
URL: https://github.com/apache/activemq-artemis/pull/4214
Ensures that when reading a string the readable buffer consumes the bytes by advancing the read index as defined in the interface API docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] tabish121 commented on pull request #4214: ARTEMIS-3990 Ensure that readable buffer string read consumes the bytes
Posted by GitBox <gi...@apache.org>.
tabish121 commented on PR #4214:
URL: https://github.com/apache/activemq-artemis/pull/4214#issuecomment-1245949122
The vertx code was patched awhile ago: https://github.com/vert-x3/vertx-proton/commit/fd91d805c8e1dd546662b9b2c70f73b81c0e7f49
As was Qpid JMS but I missed that there was yet another version in Artemis although it apparently isn't getting used like the NettyReadable one is as it doesn't cause tests to fail when running against my proton-j branch where I've removed all the unnecessary buffer slicing and duplicating it was doing just to read an array from a buffer. I can look at the other usage in Artemis as try and patch that as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4214: ARTEMIS-3990 Ensure that readable buffer string read consumes the bytes
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4214:
URL: https://github.com/apache/activemq-artemis/pull/4214#issuecomment-1245937852
@tabish121 this was copied and paste from somewhere I don't know where it came from now..
By looking right now... I see that io.vertx.proton.impl.ProtonReadableBufferImpl is doing the same, and there are other places in the artemis code that are also doing it... (for instance AmqpReadableBuffer from the artemis-amqp-protocol).
How did you find this? and should we fix the other places as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #4214: ARTEMIS-3990 Ensure that readable buffer string read consumes the bytes
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged PR #4214:
URL: https://github.com/apache/activemq-artemis/pull/4214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4214: ARTEMIS-3990 Ensure that readable buffer string read consumes the bytes
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4214:
URL: https://github.com/apache/activemq-artemis/pull/4214#issuecomment-1245955848
@tabish121 I just looked over AmqpReadableBuffer and that's dead code.. I'm removing it on a separate commit, don't worry about it...
Thanks Tim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4214: ARTEMIS-3990 Ensure that readable buffer string read consumes the bytes
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4214:
URL: https://github.com/apache/activemq-artemis/pull/4214#issuecomment-1245963262
@tabish121 I will include this on 2.25.1 next week by cherry-picking it into 2.25.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org