You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/10/23 19:13:43 UTC

[GitHub] [phoenix] swaroopak commented on a change in pull request #937: PHOENIX-6198 Add option to IndexTool to specify the source table for scan

swaroopak commented on a change in pull request #937:
URL: https://github.com/apache/phoenix/pull/937#discussion_r511094066



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
##########
@@ -192,6 +191,14 @@ public static IndexDisableLoggingType fromValue(byte[] value) {
         }
     }
 
+    /**
+     * Which table to use as the source table
+     */
+    public enum SourceTable {

Review comment:
       I agree with Gokcen, does not hurt to use it. In the future, we may want to use both. Would be a good extension. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org