[jira] [Commented] (FLINK-8934) Cancel slot requests for otherwisely fulfilled requests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396644#comment-16396644 ] 

ASF GitHub Bot commented on FLINK-8934:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5687

    [FLINK-8934] [flip6] Properly cancel slot requests of otherwisely fulfilled requests

    ## What is the purpose of the change
    
    Cancel slot requests at the ResourceManager if they have been completed with a different
    allocation.
    
    cc @zentol 
    
    ## Verifying this change
    
    - Adapted `SlotPoolTest#testFulfillingSlotRequestsWithUnusedOfferedSlots` to check cancellation
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixSlotRequestCancellation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5687
    
----
commit 95148aa8d6a217e4002ad823aacb3f7e0aaf4d9e
Author: Till Rohrmann <tr...@...>
Date:   2018-03-13T07:13:44Z

    [FLINK-8934] [flip6] Properly cancel slot requests of otherwisely fulfilled requests
    
    Cancel slot requests at the ResourceManager if they have been completed with a different
    allocation.

----


> Cancel slot requests for otherwisely fulfilled requests
> -------------------------------------------------------
>
>                 Key: FLINK-8934
>                 URL: https://issues.apache.org/jira/browse/FLINK-8934
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Critical
>              Labels: flip-6
>             Fix For: 1.5.0, 1.6.0
>
>
> If a slot request is fulfilled with a different allocation id, then we should cancel the other slot request at the {{ResourceManager}}. Otherwise we might have some stale slot requests which first need to time out before slots are available again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)